You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2011/07/21 11:52:57 UTC
[jira] [Created] (CASSANDRA-2929) Don't include tmp files as
sstable when create column families
Don't include tmp files as sstable when create column families
--------------------------------------------------------------
Key: CASSANDRA-2929
URL: https://issues.apache.org/jira/browse/CASSANDRA-2929
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7.0
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Trivial
Fix For: 0.7.8, 0.8.2
Attachments: 0001-Don-t-include-tmp-files-as-sstables-when-creating-CF.patch
When we open a column family and populate the SSTableReader, we happen to include -tmp files. This has no change to actually happen in a real life situation, but that is what was triggering a race in the unit tests triggering spurious assertion failure in estimateRowsFromIndex.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2929) Don't include tmp files as
sstable when create column families
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069793#comment-13069793 ]
Hudson commented on CASSANDRA-2929:
-----------------------------------
Integrated in Cassandra-0.7 #535 (See [https://builds.apache.org/job/Cassandra-0.7/535/])
Don't include tmp file as sstable when creating cfs
patch by slebresne; reviewed by jbellis for CASSANDRA-2929
slebresne : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1149716
Files :
* /cassandra/branches/cassandra-0.7/CHANGES.txt
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/io/sstable/SSTable.java
> Don't include tmp files as sstable when create column families
> --------------------------------------------------------------
>
> Key: CASSANDRA-2929
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2929
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 0.7.9
>
> Attachments: 0001-Don-t-include-tmp-files-as-sstables-when-creating-CF.patch
>
>
> When we open a column family and populate the SSTableReader, we happen to include -tmp files. This has no change to actually happen in a real life situation, but that is what was triggering a race in the unit tests triggering spurious assertion failure in estimateRowsFromIndex.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2929) Don't include tmp files as
sstable when create column families
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-2929:
----------------------------------------
Attachment: 0001-Don-t-include-tmp-files-as-sstables-when-creating-CF.patch
Patch is against 0.7
> Don't include tmp files as sstable when create column families
> --------------------------------------------------------------
>
> Key: CASSANDRA-2929
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2929
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 0.7.8, 0.8.2
>
> Attachments: 0001-Don-t-include-tmp-files-as-sstables-when-creating-CF.patch
>
>
> When we open a column family and populate the SSTableReader, we happen to include -tmp files. This has no change to actually happen in a real life situation, but that is what was triggering a race in the unit tests triggering spurious assertion failure in estimateRowsFromIndex.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2929) Don't include tmp files as
sstable when create column families
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2929:
--------------------------------------
Fix Version/s: 0.8.3
> Don't include tmp files as sstable when create column families
> --------------------------------------------------------------
>
> Key: CASSANDRA-2929
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2929
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 0.7.9, 0.8.3
>
> Attachments: 0001-Don-t-include-tmp-files-as-sstables-when-creating-CF.patch
>
>
> When we open a column family and populate the SSTableReader, we happen to include -tmp files. This has no change to actually happen in a real life situation, but that is what was triggering a race in the unit tests triggering spurious assertion failure in estimateRowsFromIndex.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2929) Don't include tmp files as
sstable when create column families
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068991#comment-13068991 ]
Jonathan Ellis commented on CASSANDRA-2929:
-------------------------------------------
+1, although the flag proliferation on files() is starting to concern me
> Don't include tmp files as sstable when create column families
> --------------------------------------------------------------
>
> Key: CASSANDRA-2929
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2929
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 0.7.9
>
> Attachments: 0001-Don-t-include-tmp-files-as-sstables-when-creating-CF.patch
>
>
> When we open a column family and populate the SSTableReader, we happen to include -tmp files. This has no change to actually happen in a real life situation, but that is what was triggering a race in the unit tests triggering spurious assertion failure in estimateRowsFromIndex.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira