You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/24 23:58:40 UTC
[GitHub] [beam] chamikaramj commented on a change in pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API
chamikaramj commented on a change in pull request #12494:
URL: https://github.com/apache/beam/pull/12494#discussion_r475960972
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
Review comment:
Is this format standardized ? If so can we add a reference here ?
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -348,22 +347,17 @@ static RetryJobIdResult getRetryJobId(
UNKNOWN,
}
- @VisibleForTesting
- static TableReferenceProto.TableReference toTableRefProto(TableReference ref) {
- TableReferenceProto.TableReference.Builder builder =
- TableReferenceProto.TableReference.newBuilder();
- if (ref.getProjectId() != null) {
- builder.setProjectId(ref.getProjectId());
- }
- return builder.setDatasetId(ref.getDatasetId()).setTableId(ref.getTableId()).build();
+ static String toProjectResourceName(String projectName) {
+ return "projects/" + projectName;
}
- @VisibleForTesting
- static TableReference toTableRef(TableReferenceProto.TableReference ref) {
- return new TableReference()
- .setProjectId(ref.getProjectId())
- .setDatasetId(ref.getDatasetId())
- .setTableId(ref.getTableId());
+ static String toTableResourceName(TableReference tableReference) {
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org