You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/05/12 19:06:47 UTC
[GitHub] [trafficserver] jrushford opened a new pull request, #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
jrushford opened a new pull request, #8812:
URL: https://github.com/apache/trafficserver/pull/8812
Fixes #8807. I've asked Jeremy Payne, jp557198, to test and comment here as he is the issue owner.
This was originally fixed in ATS 9.2.x with PR #8365 but #8365
was big and not backported to 9.1.x as it was a late PR and
zwoop did not want to bring it into 9.1.x at that time.
Anyway, this fixes the issue where the failure count on a parent
is not incremented properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jp557198 commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
jp557198 commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1116057402
> Fixes #8807. I've asked Jeremy Payne, jp557198, to test and comment here as he is the issue owner.
>
> This was originally fixed in ATS 9.2.x with PR #8365 but #8365 was big and not backported to 9.1.x as it was a late PR and zwoop did not want to bring it into 9.1.x at that time.
>
> Anyway, this fixes the issue where the failure count on a parent is not incremented properly.
I tested your code changes against our internal branch. Failure threshold now increments as expected.
See below debug output confirming the same.
https://github.com/apache/trafficserver/issues/8807#issuecomment-1115427593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] traeak commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
traeak commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1113357220
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
randall commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1156794422
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] traeak commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
traeak commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1113375475
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
jrushford commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1113266216
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras closed pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
ywkaras closed pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
URL: https://github.com/apache/trafficserver/pull/8812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1113714795
Through no fault of this PR, the 9.1.x branch needs a few PRs merged in before these unit tests will build and run with the fedora:35 and rockylinux compilers:
* #8231
* #8683
* #8814
Once those test-only changes are merged in, then the unit tests should finish successfully for this PR (they did for me locally).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1246143856
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
jrushford commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1112635157
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
jrushford commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1113267435
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1113450236
Both the Fedora and Rockylinux builds seem to be failing due to something introduced by this patch, not transient CI issues.
Fedora:
https://ci.trafficserver.apache.org/job/Github_Builds/job/fedora/881/console
```
In file included from /usr/include/signal.h:328,
from ../../../tests/include/catch.hpp:8034,
from unit_tests/unit_test_main.cc:25:
../../../tests/include/catch.hpp:10822:58: error: call to non-'constexpr' function 'long int sysconf(int)'
10822 | static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;
| ^~~~~~~~~~~
In file included from /usr/include/bits/sigstksz.h:24,
from /usr/include/signal.h:328,
from ../../../tests/include/catch.hpp:8034,
from unit_tests/unit_test_main.cc:25:
/usr/include/unistd.h:640:17: note: 'long int sysconf(int)' declared here
640 | extern long int sysconf (int __name) __THROW;
| ^~~~~~~
In file included from unit_tests/unit_test_main.cc:25:
../../../tests/include/catch.hpp:10881:45: error: size of array 'altStackMem' is not an integral constant-expression
10881 | char FatalConditionHandler::altStackMem[sigStackSize] = {};
| ^~~~~~~~~~~~
make[2]: *** [Makefile:974: unit_tests/test_tscpputil-unit_test_main.o] Error 1
make[2]: Leaving directory '/home/jenkins/workspace/Github_Builds/fedora/src/src/tscpp/util'
make[1]: *** [Makefile:1313: check-am] Error 2
make[1]: Leaving directory '/home/jenkins/workspace/Github_Builds/fedora/src/src/tscpp/util'
make: *** [Makefile:865: check-recursive] Error 1
```
RockyLinux:
https://ci.trafficserver.apache.org/job/Github_Builds/job/rocky/279/console
```
FAIL: test_librecords
=====================
/home/jenkins/workspace/Github_Builds/rocky/src/lib/records/.libs/test_librecords: error while loading shared libraries: libssl.so.81.1.1: cannot open shared object file: No such file or directory
FAIL test_librecords (exit status: 127)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
randall commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1156453897
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
ywkaras commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1123926095
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
jrushford commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1113399235
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
jrushford commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1112635794
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jrushford commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
jrushford commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1112666836
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
randall commented on PR #8812:
URL: https://github.com/apache/trafficserver/pull/8812#issuecomment-1156785483
[approve ci fedora]
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] closed pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #8812: Fixes issue #8807 nexthop failure threshold in ATS 9.1.x
URL: https://github.com/apache/trafficserver/pull/8812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org