You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Leonardo Uribe <lu...@gmail.com> on 2014/04/16 19:17:44 UTC
[VOTE] Release of MyFaces Core 2.2.3
Hi,
I was running the needed tasks to get the 2.2.3 release of Apache
MyFaces core out.
The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip).
Please note that this vote concerns all of the following parts:
1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
The artifacts were deployed on nexus repo [1] and to my private
Apache account [3] for binary and source packages.
The release notes could be found at [4].
Also the clirr test does not show binary incompatibilities with myfaces-api.
Please take a look at the "2.2.3" artifacts and vote!
Please note: This vote is "majority approval" with a minimum of three
+1 votes (see [3]).
------------------------------------------------
[ ] +1 for community members who have reviewed the bits
[ ] +0
[ ] -1 for fatal flaws that should cause these bits not to be released,
and why..............
------------------------------------------------
Thanks,
Leonardo Uribe
[1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
[2] http://www.apache.org/foundation/voting.html#ReleaseVotes
[3] http://people.apache.org/~lu4242/myfaces223binsrc
[4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Mark Struberg <st...@yahoo.de>.
+1
LieGrue,
strub
On Wednesday, 16 April 2014, 19:18, Leonardo Uribe <lu...@gmail.com> wrote:
+1
>
>
>2014-04-16 19:17 GMT+02:00 Leonardo Uribe <lu...@gmail.com>:
>> Hi,
>>
>> I was running the needed tasks to get the 2.2.3 release of Apache
>> MyFaces core out.
>>
>> The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip).
>>
>> Please note that this vote concerns all of the following parts:
>> 1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
>> 2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
>>
>> The artifacts were deployed on nexus repo [1] and to my private
>> Apache account [3] for binary and source packages.
>>
>> The release notes could be found at [4].
>>
>> Also the clirr test does not show binary incompatibilities with myfaces-api.
>>
>> Please take a look at the "2.2.3" artifacts and vote!
>>
>> Please note: This vote is "majority approval" with a minimum of three
>> +1 votes (see [3]).
>>
>> ------------------------------------------------
>> [ ] +1 for community members who have reviewed the bits
>> [ ] +0
>> [ ] -1 for fatal flaws that should cause these bits not to be released,
>> and why..............
>> ------------------------------------------------
>>
>> Thanks,
>> Leonardo Uribe
>>
>> [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
>> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
>> [3] http://people.apache.org/~lu4242/myfaces223binsrc
>> [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543
>
>
>
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Leonardo Uribe <lu...@gmail.com>.
+1
2014-04-16 19:17 GMT+02:00 Leonardo Uribe <lu...@gmail.com>:
> Hi,
>
> I was running the needed tasks to get the 2.2.3 release of Apache
> MyFaces core out.
>
> The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip).
>
> Please note that this vote concerns all of the following parts:
> 1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
> 2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
>
> The artifacts were deployed on nexus repo [1] and to my private
> Apache account [3] for binary and source packages.
>
> The release notes could be found at [4].
>
> Also the clirr test does not show binary incompatibilities with myfaces-api.
>
> Please take a look at the "2.2.3" artifacts and vote!
>
> Please note: This vote is "majority approval" with a minimum of three
> +1 votes (see [3]).
>
> ------------------------------------------------
> [ ] +1 for community members who have reviewed the bits
> [ ] +0
> [ ] -1 for fatal flaws that should cause these bits not to be released,
> and why..............
> ------------------------------------------------
>
> Thanks,
> Leonardo Uribe
>
> [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
> https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
> [3] http://people.apache.org/~lu4242/myfaces223binsrc
> [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Leonardo Uribe <lu...@gmail.com>.
Hi
I have tried adding this fragment on core/parent/pom.xml
<profile>
<id>prepare-release</id>
<activation>
<property>
<name>prepareRelease</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<artifactId>maven-release-plugin</artifactId>
<configuration>
<arguments>-DprepareRelease</arguments>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
It works, so I'll run again the release procedure and send another
vote request to the mailing list.
regards,
Leonardo Uribe
2014-04-17 13:42 GMT+02:00 Leonardo Uribe <lu...@gmail.com>:
> I usually do wiki page for each release. The one for 2.2.3 is here:
>
> http://wiki.apache.org/myfaces/CoreRelease223
>
> There are two options, or we put the rat plugin command at the beginning,
> or we add the plugin when the release preparations are done. The idea is
> if a file miss the license, the rat plugin will stop the release when:
>
> mvn release:prepare
> -DtagBase=https://svn.apache.org/repos/asf/myfaces/shared/tags
> -DdryRun=true
>
> is executed. For example, clirr plugin and animal sniffer plugin are
> executed in that way. I'll check how can we do it, and fix it once for all.
> The only thing I don't like with this situation is execute the TCK again,
> because it usually takes some time, so probably the next vote
> attempt will be on this weekend.
>
> regards,
>
> Leonardo Uribe
>
>
> 2014-04-17 13:19 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:
>> On Thu, Apr 17, 2014 at 7:10 AM, Leonardo Uribe <lu...@gmail.com> wrote:
>>> The problem is rat plugin is
>>> never executed automatically as part of the release, so there is no chance
>>> to detect and fix it early. I'll take a look at that.
>>
>> I really hate having to vote against a release just because we missed
>> license headers. Even if we can't make running rat an automatic part
>> of the release maven task, maybe you can add a new step (mvn
>> apache-rat:check) in the release process document of running rat so it
>> always happens? I wasn't sure what you are using as a template for
>> each release document or I would have added the step in there myself.
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Leonardo Uribe <lu...@gmail.com>.
I usually do wiki page for each release. The one for 2.2.3 is here:
http://wiki.apache.org/myfaces/CoreRelease223
There are two options, or we put the rat plugin command at the beginning,
or we add the plugin when the release preparations are done. The idea is
if a file miss the license, the rat plugin will stop the release when:
mvn release:prepare
-DtagBase=https://svn.apache.org/repos/asf/myfaces/shared/tags
-DdryRun=true
is executed. For example, clirr plugin and animal sniffer plugin are
executed in that way. I'll check how can we do it, and fix it once for all.
The only thing I don't like with this situation is execute the TCK again,
because it usually takes some time, so probably the next vote
attempt will be on this weekend.
regards,
Leonardo Uribe
2014-04-17 13:19 GMT+02:00 Mike Kienenberger <mk...@gmail.com>:
> On Thu, Apr 17, 2014 at 7:10 AM, Leonardo Uribe <lu...@gmail.com> wrote:
>> The problem is rat plugin is
>> never executed automatically as part of the release, so there is no chance
>> to detect and fix it early. I'll take a look at that.
>
> I really hate having to vote against a release just because we missed
> license headers. Even if we can't make running rat an automatic part
> of the release maven task, maybe you can add a new step (mvn
> apache-rat:check) in the release process document of running rat so it
> always happens? I wasn't sure what you are using as a template for
> each release document or I would have added the step in there myself.
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Mike Kienenberger <mk...@gmail.com>.
On Thu, Apr 17, 2014 at 7:10 AM, Leonardo Uribe <lu...@gmail.com> wrote:
> The problem is rat plugin is
> never executed automatically as part of the release, so there is no chance
> to detect and fix it early. I'll take a look at that.
I really hate having to vote against a release just because we missed
license headers. Even if we can't make running rat an automatic part
of the release maven task, maybe you can add a new step (mvn
apache-rat:check) in the release process document of running rat so it
always happens? I wasn't sure what you are using as a template for
each release document or I would have added the step in there myself.
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Leonardo Uribe <lu...@gmail.com>.
Ok, so it is unavoidable. I didn't knew that. The problem is rat plugin is
never executed automatically as part of the release, so there is no chance
to detect and fix it early. I'll take a look at that.
On Apr 17, 2014 12:54 PM, "Mike Kienenberger" <mk...@gmail.com> wrote:
> You asked about licensing on test files the last time this came up as
> well so I will point to my previous reply for that topic:
>
>
> http://mail-archives.apache.org/mod_mbox/myfaces-dev/201209.mbox/%3CCAM1yOjbz2JN5ObHKfAVo-v5rvFAUZsk0yjeOJ66Pm+WejK_b8A@mail.gmail.com%3E
>
> As for a quick fix release, It doesn't matter whether a release is a
> quick fix or any other kind. The same rules apply to all releases.
>
>
>
> On Thu, Apr 17, 2014 at 6:42 AM, Leonardo Uribe <lu...@gmail.com> wrote:
> > Hi
> >
> > Those files are used for test only. Is it so important to block a quick
> fix
> > release?
> >
> > Regards
> >
> > Leonardo
> >
> > On Apr 17, 2014 11:36 AM, "Mike Kienenberger" <mk...@gmail.com>
> wrote:
> >>
> >> Sorry. -1
> >>
> >> Rat shows that we have several non-trivial files that are missing
> headers:
> >>
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml
> >>
> >> The rest of these files are not blockers, but are also showing up in
> >> rat, which makes evaluating a release take much longer. Can we add
> >> headers to them? We could also add them to the exclude list, but if
> >> the contents changed to be non-trivial, then we'd need a license
> >> anyway, so it's safer to add the license, and each of these file
> >> formats supports license comments.
> >>
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js
> >>
> >>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js
> >>
> >>
> impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml
> >> impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js
> >>
> impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml
> >> impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js
> >>
> >> These files needs to be put in the rat exclusions section as I'm
> >> fairly certain they do not support having a license in them, and they
> >> are trivial.
> >>
> >>
> >>
> impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension
> >>
> >>
> impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider
> >>
> >>
> >>
> >> On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe <lu...@gmail.com>
> wrote:
> >> > Hi,
> >> >
> >> > I was running the needed tasks to get the 2.2.3 release of Apache
> >> > MyFaces core out.
> >> >
> >> > The artifacts passed the TCK test of Feb 2013
> >> > (jsftck-2.2_26-Feb-2013.zip).
> >> >
> >> > Please note that this vote concerns all of the following parts:
> >> > 1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
> >> > 2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
> >> >
> >> > The artifacts were deployed on nexus repo [1] and to my private
> >> > Apache account [3] for binary and source packages.
> >> >
> >> > The release notes could be found at [4].
> >> >
> >> > Also the clirr test does not show binary incompatibilities with
> >> > myfaces-api.
> >> >
> >> > Please take a look at the "2.2.3" artifacts and vote!
> >> >
> >> > Please note: This vote is "majority approval" with a minimum of three
> >> > +1 votes (see [3]).
> >> >
> >> > ------------------------------------------------
> >> > [ ] +1 for community members who have reviewed the bits
> >> > [ ] +0
> >> > [ ] -1 for fatal flaws that should cause these bits not to be
> released,
> >> > and why..............
> >> > ------------------------------------------------
> >> >
> >> > Thanks,
> >> > Leonardo Uribe
> >> >
> >> > [1]
> >> >
> https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
> >> >
> >> >
> https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
> >> > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
> >> > [3] http://people.apache.org/~lu4242/myfaces223binsrc
> >> > [4]
> >> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543
>
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Mike Kienenberger <mk...@gmail.com>.
For what it's worth, if you and two other people disagree that the
licensing of these files should be a blocking issue, you can still do
a release. As the release manager, the final decision is yours so
long as you have a majority approval. [1]
[1] https://www.apache.org/foundation/voting.html#ReleaseVotes
On Thu, Apr 17, 2014 at 6:53 AM, Mike Kienenberger <mk...@gmail.com> wrote:
> You asked about licensing on test files the last time this came up as
> well so I will point to my previous reply for that topic:
>
> http://mail-archives.apache.org/mod_mbox/myfaces-dev/201209.mbox/%3CCAM1yOjbz2JN5ObHKfAVo-v5rvFAUZsk0yjeOJ66Pm+WejK_b8A@mail.gmail.com%3E
>
> As for a quick fix release, It doesn't matter whether a release is a
> quick fix or any other kind. The same rules apply to all releases.
>
>
>
> On Thu, Apr 17, 2014 at 6:42 AM, Leonardo Uribe <lu...@gmail.com> wrote:
>> Hi
>>
>> Those files are used for test only. Is it so important to block a quick fix
>> release?
>>
>> Regards
>>
>> Leonardo
>>
>> On Apr 17, 2014 11:36 AM, "Mike Kienenberger" <mk...@gmail.com> wrote:
>>>
>>> Sorry. -1
>>>
>>> Rat shows that we have several non-trivial files that are missing headers:
>>>
>>>
>>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml
>>>
>>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml
>>>
>>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml
>>>
>>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml
>>>
>>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml
>>>
>>> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml
>>>
>>> The rest of these files are not blockers, but are also showing up in
>>> rat, which makes evaluating a release take much longer. Can we add
>>> headers to them? We could also add them to the exclude list, but if
>>> the contents changed to be non-trivial, then we'd need a license
>>> anyway, so it's safer to add the license, and each of these file
>>> formats supports license comments.
>>>
>>>
>>> impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js
>>>
>>> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js
>>>
>>> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js
>>>
>>> impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml
>>> impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js
>>> impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml
>>> impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js
>>>
>>> These files needs to be put in the rat exclusions section as I'm
>>> fairly certain they do not support having a license in them, and they
>>> are trivial.
>>>
>>>
>>> impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension
>>>
>>> impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider
>>>
>>>
>>>
>>> On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe <lu...@gmail.com> wrote:
>>> > Hi,
>>> >
>>> > I was running the needed tasks to get the 2.2.3 release of Apache
>>> > MyFaces core out.
>>> >
>>> > The artifacts passed the TCK test of Feb 2013
>>> > (jsftck-2.2_26-Feb-2013.zip).
>>> >
>>> > Please note that this vote concerns all of the following parts:
>>> > 1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
>>> > 2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
>>> >
>>> > The artifacts were deployed on nexus repo [1] and to my private
>>> > Apache account [3] for binary and source packages.
>>> >
>>> > The release notes could be found at [4].
>>> >
>>> > Also the clirr test does not show binary incompatibilities with
>>> > myfaces-api.
>>> >
>>> > Please take a look at the "2.2.3" artifacts and vote!
>>> >
>>> > Please note: This vote is "majority approval" with a minimum of three
>>> > +1 votes (see [3]).
>>> >
>>> > ------------------------------------------------
>>> > [ ] +1 for community members who have reviewed the bits
>>> > [ ] +0
>>> > [ ] -1 for fatal flaws that should cause these bits not to be released,
>>> > and why..............
>>> > ------------------------------------------------
>>> >
>>> > Thanks,
>>> > Leonardo Uribe
>>> >
>>> > [1]
>>> > https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
>>> >
>>> > https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
>>> > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
>>> > [3] http://people.apache.org/~lu4242/myfaces223binsrc
>>> > [4]
>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Mike Kienenberger <mk...@gmail.com>.
You asked about licensing on test files the last time this came up as
well so I will point to my previous reply for that topic:
http://mail-archives.apache.org/mod_mbox/myfaces-dev/201209.mbox/%3CCAM1yOjbz2JN5ObHKfAVo-v5rvFAUZsk0yjeOJ66Pm+WejK_b8A@mail.gmail.com%3E
As for a quick fix release, It doesn't matter whether a release is a
quick fix or any other kind. The same rules apply to all releases.
On Thu, Apr 17, 2014 at 6:42 AM, Leonardo Uribe <lu...@gmail.com> wrote:
> Hi
>
> Those files are used for test only. Is it so important to block a quick fix
> release?
>
> Regards
>
> Leonardo
>
> On Apr 17, 2014 11:36 AM, "Mike Kienenberger" <mk...@gmail.com> wrote:
>>
>> Sorry. -1
>>
>> Rat shows that we have several non-trivial files that are missing headers:
>>
>>
>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml
>>
>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml
>>
>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml
>>
>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml
>>
>> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml
>>
>> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml
>>
>> The rest of these files are not blockers, but are also showing up in
>> rat, which makes evaluating a release take much longer. Can we add
>> headers to them? We could also add them to the exclude list, but if
>> the contents changed to be non-trivial, then we'd need a license
>> anyway, so it's safer to add the license, and each of these file
>> formats supports license comments.
>>
>>
>> impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js
>>
>> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js
>>
>> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js
>>
>> impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml
>> impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js
>> impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml
>> impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js
>>
>> These files needs to be put in the rat exclusions section as I'm
>> fairly certain they do not support having a license in them, and they
>> are trivial.
>>
>>
>> impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension
>>
>> impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider
>>
>>
>>
>> On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe <lu...@gmail.com> wrote:
>> > Hi,
>> >
>> > I was running the needed tasks to get the 2.2.3 release of Apache
>> > MyFaces core out.
>> >
>> > The artifacts passed the TCK test of Feb 2013
>> > (jsftck-2.2_26-Feb-2013.zip).
>> >
>> > Please note that this vote concerns all of the following parts:
>> > 1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
>> > 2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
>> >
>> > The artifacts were deployed on nexus repo [1] and to my private
>> > Apache account [3] for binary and source packages.
>> >
>> > The release notes could be found at [4].
>> >
>> > Also the clirr test does not show binary incompatibilities with
>> > myfaces-api.
>> >
>> > Please take a look at the "2.2.3" artifacts and vote!
>> >
>> > Please note: This vote is "majority approval" with a minimum of three
>> > +1 votes (see [3]).
>> >
>> > ------------------------------------------------
>> > [ ] +1 for community members who have reviewed the bits
>> > [ ] +0
>> > [ ] -1 for fatal flaws that should cause these bits not to be released,
>> > and why..............
>> > ------------------------------------------------
>> >
>> > Thanks,
>> > Leonardo Uribe
>> >
>> > [1]
>> > https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
>> >
>> > https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
>> > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
>> > [3] http://people.apache.org/~lu4242/myfaces223binsrc
>> > [4]
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Leonardo Uribe <lu...@gmail.com>.
Hi
Those files are used for test only. Is it so important to block a quick fix
release?
Regards
Leonardo
On Apr 17, 2014 11:36 AM, "Mike Kienenberger" <mk...@gmail.com> wrote:
> Sorry. -1
>
> Rat shows that we have several non-trivial files that are missing headers:
>
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml
>
> The rest of these files are not blockers, but are also showing up in
> rat, which makes evaluating a release take much longer. Can we add
> headers to them? We could also add them to the exclude list, but if
> the contents changed to be non-trivial, then we'd need a license
> anyway, so it's safer to add the license, and each of these file
> formats supports license comments.
>
>
> impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js
>
> impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml
> impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js
> impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml
> impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js
>
> These files needs to be put in the rat exclusions section as I'm
> fairly certain they do not support having a license in them, and they
> are trivial.
>
>
> impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension
>
> impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider
>
>
>
> On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> > Hi,
> >
> > I was running the needed tasks to get the 2.2.3 release of Apache
> > MyFaces core out.
> >
> > The artifacts passed the TCK test of Feb 2013
> (jsftck-2.2_26-Feb-2013.zip).
> >
> > Please note that this vote concerns all of the following parts:
> > 1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
> > 2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
> >
> > The artifacts were deployed on nexus repo [1] and to my private
> > Apache account [3] for binary and source packages.
> >
> > The release notes could be found at [4].
> >
> > Also the clirr test does not show binary incompatibilities with
> myfaces-api.
> >
> > Please take a look at the "2.2.3" artifacts and vote!
> >
> > Please note: This vote is "majority approval" with a minimum of three
> > +1 votes (see [3]).
> >
> > ------------------------------------------------
> > [ ] +1 for community members who have reviewed the bits
> > [ ] +0
> > [ ] -1 for fatal flaws that should cause these bits not to be released,
> > and why..............
> > ------------------------------------------------
> >
> > Thanks,
> > Leonardo Uribe
> >
> > [1]
> https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
> >
> https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
> > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
> > [3] http://people.apache.org/~lu4242/myfaces223binsrc
> > [4]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543
>
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Mike Kienenberger <mk...@gmail.com>.
I've cleaned up all of these files. Trunk builds and passes rat, so a
new release candidate should pass rat as well.
On Thu, Apr 17, 2014 at 5:35 AM, Mike Kienenberger <mk...@gmail.com> wrote:
> Sorry. -1
>
> Rat shows that we have several non-trivial files that are missing headers:
>
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml
> impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml
>
> The rest of these files are not blockers, but are also showing up in
> rat, which makes evaluating a release take much longer. Can we add
> headers to them? We could also add them to the exclude list, but if
> the contents changed to be non-trivial, then we'd need a license
> anyway, so it's safer to add the license, and each of these file
> formats supports license comments.
>
> impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js
> impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js
> impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml
> impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js
> impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml
> impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js
>
> These files needs to be put in the rat exclusions section as I'm
> fairly certain they do not support having a license in them, and they
> are trivial.
>
> impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension
> impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider
>
>
>
> On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe <lu...@gmail.com> wrote:
>> Hi,
>>
>> I was running the needed tasks to get the 2.2.3 release of Apache
>> MyFaces core out.
>>
>> The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip).
>>
>> Please note that this vote concerns all of the following parts:
>> 1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
>> 2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
>>
>> The artifacts were deployed on nexus repo [1] and to my private
>> Apache account [3] for binary and source packages.
>>
>> The release notes could be found at [4].
>>
>> Also the clirr test does not show binary incompatibilities with myfaces-api.
>>
>> Please take a look at the "2.2.3" artifacts and vote!
>>
>> Please note: This vote is "majority approval" with a minimum of three
>> +1 votes (see [3]).
>>
>> ------------------------------------------------
>> [ ] +1 for community members who have reviewed the bits
>> [ ] +0
>> [ ] -1 for fatal flaws that should cause these bits not to be released,
>> and why..............
>> ------------------------------------------------
>>
>> Thanks,
>> Leonardo Uribe
>>
>> [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
>> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
>> [3] http://people.apache.org/~lu4242/myfaces223binsrc
>> [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
Posted by Mike Kienenberger <mk...@gmail.com>.
Sorry. -1
Rat shows that we have several non-trivial files that are missing headers:
impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml
impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml
impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml
impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml
impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml
impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml
The rest of these files are not blockers, but are also showing up in
rat, which makes evaluating a release take much longer. Can we add
headers to them? We could also add them to the exclude list, but if
the contents changed to be non-trivial, then we'd need a license
anyway, so it's safer to add the license, and each of these file
formats supports license comments.
impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js
impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js
impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js
impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml
impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js
impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml
impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js
These files needs to be put in the rat exclusions section as I'm
fairly certain they do not support having a license in them, and they
are trivial.
impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension
impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider
On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe <lu...@gmail.com> wrote:
> Hi,
>
> I was running the needed tasks to get the 2.2.3 release of Apache
> MyFaces core out.
>
> The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip).
>
> Please note that this vote concerns all of the following parts:
> 1. Maven artifact group "org.apache.myfaces.shared" v4.2.2 [1]
> 2. Maven artifact group "org.apache.myfaces.core" v2.2.3 [1]
>
> The artifacts were deployed on nexus repo [1] and to my private
> Apache account [3] for binary and source packages.
>
> The release notes could be found at [4].
>
> Also the clirr test does not show binary incompatibilities with myfaces-api.
>
> Please take a look at the "2.2.3" artifacts and vote!
>
> Please note: This vote is "majority approval" with a minimum of three
> +1 votes (see [3]).
>
> ------------------------------------------------
> [ ] +1 for community members who have reviewed the bits
> [ ] +0
> [ ] -1 for fatal flaws that should cause these bits not to be released,
> and why..............
> ------------------------------------------------
>
> Thanks,
> Leonardo Uribe
>
> [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/
> https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/
> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes
> [3] http://people.apache.org/~lu4242/myfaces223binsrc
> [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12326543