You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2018/08/27 09:01:00 UTC

[jira] [Commented] (ARTEMIS-2054) Artemis appears to never issue a JMS callback on error

    [ https://issues.apache.org/jira/browse/ARTEMIS-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593350#comment-16593350 ] 

Robbie Gemmell commented on ARTEMIS-2054:
-----------------------------------------

Probably a duplicate of the discussion/work on ARTEMIS-1545.

> Artemis appears to never issue a JMS callback on error
> ------------------------------------------------------
>
>                 Key: ARTEMIS-2054
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2054
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.6.2
>         Environment: I'm trying to use artemis for Brave (zipkin java tracer) testing of JMS 2.0 implementation.
> I've noticed that the completion listener is never called on error. This might be a concern beyond my testing. Here's how I found this..
> I traced the use of CompletionListener in org.apache.activemq.artemis.jms.client.ActiveMQMessageProducer. At what's currently line 515, it is used, but wrapped with a type that will never call the callback.
> {{         if (completionListener != null) {}}
> {{            clientProducer.send(address, coreMessage, new CompletionListenerWrapper(completionListener, jmsMessage, this));}}
> {{         } else {}}
> {{            clientProducer.send(address, coreMessage);}}
> {{         }}}
> {{Also, all catch blocks won't call the callback either. It is possible I missed something.}}
>            Reporter: Adrian Cole
>            Priority: Major
>
> I'm trying to use artemis for Brave (zipkin java tracer) testing of JMS 2.0 implementation.
> I've noticed that the completion listener is never called on error. This might be a concern beyond my testing. Here's how I found this..
>  
> I traced the use of CompletionListener in org.apache.activemq.artemis.jms.client.ActiveMQMessageProducer. At what's currently line 515, it is used, but wrapped with a type that will never call the callback.
> {{code}}
>          if (completionListener != null) {
>             clientProducer.send(address, coreMessage, new CompletionListenerWrapper(completionListener, jmsMessage, this));
>          } else {
>             clientProducer.send(address, coreMessage);
>          }
> {{code}}
> Also, all catch blocks won't call the callback either.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)