You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2018/03/22 20:53:56 UTC
Review Request 66228: Added call/event for updating framework info.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added call/event for updating framework info.
Diffs
-----
include/mesos/scheduler/scheduler.proto 7a90355c3d1a362ebb4fdb63bfe1fba8aca60d5b
include/mesos/v1/scheduler/scheduler.proto f08fdfbab2a13d1104e7be4b42bf20e9048ab562
Diff: https://reviews.apache.org/r/66228/diff/1/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66228: Added Call for updating framework info.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/
-----------------------------------------------------------
(Updated May 9, 2018, 9:14 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added Call for updating framework info.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f
include/mesos/v1/scheduler/scheduler.proto fcfec5e417463103e98dd6917722b4fde41cac7c
Diff: https://reviews.apache.org/r/66228/diff/9/
Changes: https://reviews.apache.org/r/66228/diff/8-9/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66228: Added Call for updating framework info.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/#review202532
-----------------------------------------------------------
include/mesos/scheduler/scheduler.proto
Lines 479 (patched)
<https://reviews.apache.org/r/66228/#comment284323>
Should we document the 200 OK response somewhere?
- Benjamin Mahler
On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66228/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 8:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Call for updating framework info.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f
> include/mesos/v1/scheduler/scheduler.proto fcfec5e417463103e98dd6917722b4fde41cac7c
>
>
> Diff: https://reviews.apache.org/r/66228/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66228: Added Call for updating framework info.
Posted by Benjamin Mahler <bm...@apache.org>.
> On May 7, 2018, 2:41 a.m., Benjamin Mahler wrote:
> >
Can you add some description to this change?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/#review202528
-----------------------------------------------------------
On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66228/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 8:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Call for updating framework info.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f
> include/mesos/v1/scheduler/scheduler.proto fcfec5e417463103e98dd6917722b4fde41cac7c
>
>
> Diff: https://reviews.apache.org/r/66228/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66228: Added Call for updating framework info.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/#review202528
-----------------------------------------------------------
include/mesos/scheduler/scheduler.proto
Lines 477-478 (patched)
<https://reviews.apache.org/r/66228/#comment284321>
Per discussion, can you document that this is inconsistent with the re-registration allowed updates and add a TODO indicating that we'll make it consistent in a follow up patch and allow the same changes in both approaches?
Alternatively, this chain could be updated to make the two paths consistent.
- Benjamin Mahler
On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66228/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 8:19 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Call for updating framework info.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f
> include/mesos/v1/scheduler/scheduler.proto fcfec5e417463103e98dd6917722b4fde41cac7c
>
>
> Diff: https://reviews.apache.org/r/66228/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 66228: Added Call for updating framework info.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/
-----------------------------------------------------------
(Updated April 20, 2018, 4:19 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added Call for updating framework info.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f
include/mesos/v1/scheduler/scheduler.proto 25ebcfcb07cb4fb928dcfdc242bb6509c9080491
Diff: https://reviews.apache.org/r/66228/diff/5/
Changes: https://reviews.apache.org/r/66228/diff/4-5/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 66228: Added Call for updating framework info.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/
-----------------------------------------------------------
(Updated April 11, 2018, 1:28 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added Call for updating framework info.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f
include/mesos/v1/scheduler/scheduler.proto 25ebcfcb07cb4fb928dcfdc242bb6509c9080491
Diff: https://reviews.apache.org/r/66228/diff/4/
Changes: https://reviews.apache.org/r/66228/diff/3-4/
Testing
-------
Thanks,
Kapil Arya