You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "OIiveirra (via GitHub)" <gi...@apache.org> on 2026/10/23 11:56:33 UTC
[PR] [fix](be) Keep credentials out of fragment execution logs (branch-4.2) [doris]
OIiveirra opened a new pull request, #69543:
URL: https://github.com/apache/doris/pull/69543
### What problem does this PR solve?
Related PR: https://github.com/apache/doris/pull/69540
Problem Summary: FragmentMgr logs complete pipeline execution parameters at VLOG(10), including file-scan properties, descriptor passwords and transaction tokens. The external open path also logs the complete query plan at VLOG(1). Replace these dumps with query/fragment identifiers and instance counts without modifying execution parameters.
```diff
- Log complete execution parameters and external query plans
+ Log fixed identifiers and instance counts
```
### Release note
Verbose fragment execution logs no longer include full execution parameters, query options or external query plans that may contain credentials.
### Evidence
- Added three summary tests covering identifiers, absent optional fields, synthetic S3/token/password properties and unchanged input parameters.
- Added two tests that enable VLOG(10), capture real pipeline/external request logs and check synthetic credentials are absent. Existing failure injection stops execution after request logging.
- clang-format 16 and whitespace checks passed. Focused BE unit tests are blocked before execution because this task environment lacks the branch-required `libgoogle_cloud_cpp_oauth2.a`. This PR remains a draft.
### Check List (For Author)
- Test:
- [ ] Unit Test: `FragmentParamsLogTest.*:FragmentMgrLogTest.*` (pending local validation)
- Behavior changed:
- [x] Yes. Verbose diagnostics now contain fixed identifiers and counts rather than full parameter dumps.
- Does this need documentation?
- [x] No.
### Merge Danger
**Door:** two-way
**Blast Radius:** diagnostics
Execution and protocol parameters are unchanged; only verbose log contents change.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep credentials out of fragment execution logs (branch-4.2) [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #69543:
URL: https://github.com/apache/doris/pull/69543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep credentials out of fragment execution logs (branch-4.2) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69543:
URL: https://github.com/apache/doris/pull/69543#issuecomment-6364309379
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep credentials out of fragment execution logs (branch-4.2) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69543:
URL: https://github.com/apache/doris/pull/69543#issuecomment-6376332115
# BE UT Coverage Report
Increment line coverage `100.00% (9/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/01ffe8c343af3b5d44e853f653dd96e6ec63e4b9_01ffe8c343af3b5d44e853f653dd96e6ec63e4b9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/01ffe8c343af3b5d44e853f653dd96e6ec63e4b9_01ffe8c343af3b5d44e853f653dd96e6ec63e4b9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 64.29% (29910/46527) |
| Line Coverage | 49.13% (315481/642174) |
| Region Coverage | 44.99% (254169/565006) |
| Branch Coverage | 46.60% (119882/257281) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep credentials out of fragment execution logs (branch-4.2) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69543:
URL: https://github.com/apache/doris/pull/69543#issuecomment-6376397186
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (9/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69543_01ffe8c343af3b5d44e853f653dd96e6ec63e4b9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69543_01ffe8c343af3b5d44e853f653dd96e6ec63e4b9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.33% (34487/45184) |
| Line Coverage | 61.16% (389469/636795) |
| Region Coverage | 57.95% (327962/565917) |
| Branch Coverage | 58.93% (151434/256989) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep credentials out of fragment execution logs (branch-4.2) [doris]
Posted by "OIiveirra (via GitHub)" <gi...@apache.org>.
OIiveirra commented on PR #69543:
URL: https://github.com/apache/doris/pull/69543#issuecomment-6366705184
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep credentials out of fragment execution logs (branch-4.2) [doris]
Posted by "OIiveirra (via GitHub)" <gi...@apache.org>.
OIiveirra commented on PR #69543:
URL: https://github.com/apache/doris/pull/69543#issuecomment-6366705976
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org