[GitHub] john-bodley commented on issue #5119: [sqllab] allow gamma users to access their SQLLab views

[GitBox <gi...@apache.org>]

john-bodley commented on issue #5119: [sqllab] allow gamma users to access their SQLLab views
URL: https://github.com/apache/incubator-superset/pull/5119#issuecomment-398908654
 
 
   Sorry I think this PR only remedies part of the problem. Fundamentally the `DashboardFilter`, `SliceFilter`, and `DatasourceFilter` use the corresponding `perm` field to filter out ineligible entities. The `perm` filter is datasource (and not schema etc. specific) and thus a Gamma user can only see datasources which have been explicitly defined for the role.
   
   This PR remedies the problem somewhat by also including datasources owned by the current user (which may not match the permission filter), but does not address the issue of other Gamma users who may be entitled to access it. I wonder if there's a solution which correctly addresses this issue, i.e., the filters correctly list the entity the current user is able to access. 
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org