[jira] [Commented] (KAFKA-6309) add support for getting topic defaults from AdminClient

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324854#comment-16324854 ] 

ASF GitHub Bot commented on KAFKA-6309:
---------------------------------------

guozhangwang opened a new pull request #4421: KAFKA-6309: Return value getter based on KTable materialization status
URL: https://github.com/apache/kafka/pull/4421
 
 
   This is a bug fix that is composed of two parts:
   
   1. The major part is, for all operators that is generating a KTable, we should construct its value getter based on whether the KTable itself is materialized.
   1.a If yes, then query the materialized store directly for value getter.
   1.b If not, then hand over to its parents value getter (recursively) and apply the computation to return.
   
   2. The minor part is, in KStreamImpl, when joining with a table, we should connect with table's `valueGetterSupplier().storeNames()`, not the `internalStoreName()` as the latter always assume that the KTable is materialized, but that is not always true.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> add support for getting topic defaults from AdminClient
> -------------------------------------------------------
>
>                 Key: KAFKA-6309
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6309
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: dan norwood
>            Assignee: dan norwood
>
> kip here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-234%3A+add+support+for+getting+topic+defaults+from+AdminClient



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)