[jira] [Comment Edited] (HBASE-19703) Functionality added as part of HBASE-12583 is not working after moving the split code to master

["Rajeshbabu Chintaguntla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347440#comment-16347440 ] 

Rajeshbabu Chintaguntla edited comment on HBASE-19703 at 1/31/18 7:30 PM:
--------------------------------------------------------------------------

[~chia7712] 
bq. My point is that the lack of region object make many methods of splitpolicy unused since splitpolicy assume the region object is not null. Current solution is like we mock a splitpolicy for spying specified method. The method, now, have a obscure limit that no region can be referenced. I just worry the method may confuse other policy developers.
Agree with you. 
bq. Perhaps we should got rid of the method from splitpolicy and find alternative way.
We can have alternative way using a column family level attribute to make a decision whether to skip store file range check or not. Will raise an issue for this and work on it. Till then we can have this fix.
Thanks.


was (Author: rajeshbabu):
[~chia7712] 
bq. My point is that the lack of region object make many methods of splitpolicy unused since splitpolicy assume the region object is not null. Current solution is like we mock a splitpolicy for spying specified method. The method, now, have a obscure limit that no region can be referenced. I just worry the method may confuse other policy developers.
Agree with you. 
bq. Perhaps we should got rid of the method from splitpolicy and find alternative way.
We can have alternative way using a column family level attribute to make a decision whether to skip store file range check or not. Will raise an issue for this and work on it. Till then will commit this.

> Functionality added as part of HBASE-12583 is not working after moving the split code to master
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19703
>                 URL: https://issues.apache.org/jira/browse/HBASE-19703
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19703-WIP.patch, HBASE-19703_v2.patch, HBASE-19703_v3.patch, HBASE-19703_v4.patch, HBASE-19703_v5.patch
>
>
> As part of HBASE-12583 we are passing split policy to HRegionFileSystem#splitStoreFile so that we can allow to create reference files even the split key is out of HFile key range. This is needed for Local Indexing implementation in Phoenix. But now after moving the split code to master just passing null for split policy.
> {noformat}
>     final String familyName = Bytes.toString(family);
>     final Path path_first =
>         regionFs.splitStoreFile(this.daughter_1_RI, familyName, sf, splitRow, false, null);
>     final Path path_second =
>         regionFs.splitStoreFile(this.daughter_2_RI, familyName, sf, splitRow, true, null);
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)