You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/25 09:03:58 UTC
[GitHub] [arrow] kou opened a new pull request, #35322: GH-35316: [C++][FlightSQL] Use RowsToBatches() instead of ArrayFromJSON() in SQLite example server
kou opened a new pull request, #35322:
URL: https://github.com/apache/arrow/pull/35322
### Rationale for this change
`ArrayFromJSON()` requires `libarrow_testing.so`. But `cpp/examples/arrow/flight_sql_example.cc` uses the SQLite example server without `libarrow_testing.so` dependency.
### What changes are included in this PR?
Use `RowsToBatches()` in `libarrow.so` instead of `ArrayFromJSON()`.
### Are these changes tested?
Yes by hand.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35322: GH-35316: [C++][FlightSQL] Use RowsToBatches() instead of ArrayFromJSON() in SQLite example server
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35322:
URL: https://github.com/apache/arrow/pull/35322#issuecomment-1522842948
Benchmark runs are scheduled for baseline = 24442530a6573cbf80df1548a2ba1b0ea5d53f82 and contender = 797f3460c15d11f3e5b12da1809644e53fd910b5. 797f3460c15d11f3e5b12da1809644e53fd910b5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/54baa8c41dd14f5cae2d220042b6b533...1e81ca3905b04a89a2f049ac4b887f62/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/13230f9cbf8f4c8993dd472298d8ccdf...ca89580d75d84717827f14708d1d4f24/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bc444bb5d89d4ce3a47c4256d7d7c080...36c7d484401d44b799fdc503d1dfdb58/)
[Finished :arrow_down:0.12% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/58c744bf70674814807df24d6b51dbf1...f9b9ce0eaa6f4a5fa6ec7c79842392dd/)
Buildkite builds:
[Finished] [`797f3460` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2781)
[Failed] [`797f3460` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2815)
[Finished] [`797f3460` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2779)
[Finished] [`797f3460` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2806)
[Finished] [`24442530` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2780)
[Failed] [`24442530` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2814)
[Finished] [`24442530` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2778)
[Finished] [`24442530` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2805)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35322: GH-35316: [C++][FlightSQL] Use RowsToBatches() instead of ArrayFromJSON() in SQLite example server
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35322:
URL: https://github.com/apache/arrow/pull/35322#issuecomment-1522595969
> Perhaps we should consider some better utilities for this.
I agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35322: GH-35316: [C++][FlightSQL] Use RowsToBatches() instead of ArrayFromJSON() in SQLite example server
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35322:
URL: https://github.com/apache/arrow/pull/35322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35322: GH-35316: [C++][FlightSQL] Use RowsToBatches() instead of ArrayFromJSON() in SQLite example server
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35322:
URL: https://github.com/apache/arrow/pull/35322#issuecomment-1521434992
* Closes: #35316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org