[GitHub] [cloudstack] ngrosc commented on issue #4519: SAML signature is optional

["ngrosc (via GitHub)" <gi...@apache.org>]

ngrosc commented on issue #4519:
URL: https://github.com/apache/cloudstack/issues/4519#issuecomment-1438780835

   @mlsorensen
   From my point of view, the origin of the IDP data doesen't matter. As long as Cloudstack does not enforce a signature, any unsigned message would be accepted and processed. 
   
   A man in the middle could easy modify the original message, remove the signature and send it to Cloudstack. Of course, as soon as the assertions are encrypted, thats not a real issue anymore.
   
   But from a security point of view, it's not uncritical when a security mechanism can be removed without any problems.
   
   I'm still thinking about a simple true/false flag named "require signed assertions". In case of not set, assertions will be processed with or without signature. But as soon as enabled, every assertion must be signed or it will be dropped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org