You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by us...@apache.org on 2011/01/23 13:27:51 UTC
svn commit: r1062409 -
/lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java
Author: uschindler
Date: Sun Jan 23 12:27:51 2011
New Revision: 1062409
URL: http://svn.apache.org/viewvc?rev=1062409&view=rev
Log:
Fix incorrect Interface override
Modified:
lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java
Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java?rev=1062409&r1=1062408&r2=1062409&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java (original)
+++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java Sun Jan 23 12:27:51 2011
@@ -977,7 +977,6 @@ public class IndexWriter implements Clos
* @throws CorruptIndexException if the index is corrupt
* @throws IOException if there is a low-level IO error
*/
- @Override
public void close() throws CorruptIndexException, IOException {
close(true);
}
Re: svn commit: r1062409 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Michael McCandless <lu...@mikemccandless.com>.
LOL yes I know.
But, still, having these comments in place before then can stop
"trapping" us.... we've broken the build (falsely) a number of times
from this...
Can you push a button in Eclipse and put that comment on? :)
Mike
On Sun, Jan 23, 2011 at 9:11 AM, Robert Muir <rc...@gmail.com> wrote:
> On Sun, Jan 23, 2011 at 8:42 AM, Michael McCandless
> <lu...@mikemccandless.com> wrote:
>> Maybe for these cases we should instead do something like:
>>
>> // @Override not until Java 1.6
>>
>> ?
>>
>>
>
> we could, but another option is that when we move to java 1.6 we can
> also "push a button" in eclipse :)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1062409 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Robert Muir <rc...@gmail.com>.
On Sun, Jan 23, 2011 at 8:42 AM, Michael McCandless
<lu...@mikemccandless.com> wrote:
> Maybe for these cases we should instead do something like:
>
> // @Override not until Java 1.6
>
> ?
>
>
we could, but another option is that when we move to java 1.6 we can
also "push a button" in eclipse :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1062409 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java
Posted by Michael McCandless <lu...@mikemccandless.com>.
Maybe for these cases we should instead do something like:
// @Override not until Java 1.6
?
Mike
On Sun, Jan 23, 2011 at 7:27 AM, <us...@apache.org> wrote:
> Author: uschindler
> Date: Sun Jan 23 12:27:51 2011
> New Revision: 1062409
>
> URL: http://svn.apache.org/viewvc?rev=1062409&view=rev
> Log:
> Fix incorrect Interface override
>
> Modified:
> lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java
>
> Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java?rev=1062409&r1=1062408&r2=1062409&view=diff
> ==============================================================================
> --- lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java (original)
> +++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexWriter.java Sun Jan 23 12:27:51 2011
> @@ -977,7 +977,6 @@ public class IndexWriter implements Clos
> * @throws CorruptIndexException if the index is corrupt
> * @throws IOException if there is a low-level IO error
> */
> - @Override
> public void close() throws CorruptIndexException, IOException {
> close(true);
> }
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org