You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/04/02 03:49:33 UTC
[GitHub] flink pull request #5799: [FLINK-7775] Remove unreferenced method PermanentB...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5799
[FLINK-7775] Remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs
## What is the purpose of the change
*This pull request remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs*
## Brief change log
- *Remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-7775
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5799
----
commit 19d786cdd426302e316df5c24f59e8976a85c108
Author: yanghua <ya...@...>
Date: 2018-04-02T03:46:44Z
[FLINK-7775] Remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs
----
---
[GitHub] flink issue #5799: [FLINK-7775] Remove unreferenced method PermanentBlobCach...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5799
hi @StefanRRichter seems this PR has not been merged but closed?
---
[GitHub] flink issue #5799: [FLINK-7775] Remove unreferenced method PermanentBlobCach...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5799
LGTM 👍 Merging.
---
[GitHub] flink issue #5799: [FLINK-7775] Remove unreferenced method PermanentBlobCach...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5799
cc @aljoscha
---
[GitHub] flink issue #5799: [FLINK-7775] Remove unreferenced method PermanentBlobCach...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5799
hi @tzulitai can you review this PR, it takes a long time, thanks~
---
[GitHub] flink issue #5799: [FLINK-7775] Remove unreferenced method PermanentBlobCach...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5799
cc @zentol
---
[GitHub] flink pull request #5799: [FLINK-7775] Remove unreferenced method PermanentB...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5799
---
[GitHub] flink issue #5799: [FLINK-7775] Remove unreferenced method PermanentBlobCach...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5799
cc @tillrohrmann
---
[GitHub] flink issue #5799: [FLINK-7775] Remove unreferenced method PermanentBlobCach...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5799
cc @zentol @GJL this PR takes a long time and the travis build error seems uncorrelated. can you review it? thanks.
---