You are viewing a plain text version of this content. The canonical link for it is here.

Posted to apps-dev@avalon.apache.org by Greg Steuck <gr...@nest.cx> on 2002/09/10 01:35:20 UTC

data-sources/data-sources/data-source

Hello,

Could somebody explain the benefit of having data-sources element
inside the configuration for
o.a.a.cornerstone.blocks.datasource.DefaultDataSourceSelector?

In my case it leads to a somewhat ugly configuration items similar to:

  <data-sources>
    <data-sources>
      <data-source name="default"/>
    </data-sources>
  </data-sources>

Am I missing something? If not, I attached a patch that removes
that extra data-sources element...

Thanks
Greg

Re: data-sources/data-sources/data-source

Posted by Greg Steuck <gr...@nest.cx>.

>>>>> "Peter" == Peter Donald <pe...@apache.org> writes:

    Peter> Seems reasomable change ;) I applied the patch with slight
    Peter> modification.  Instead of just ignoring the old configuration
    Peter> format it will detect it and issue a warning instead.

    Peter> Could you download it and make sure it all still works
    Peter> properly ? :)

Yep, just tried it. Works fine and even prodded me to remove the
extra element.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: data-sources/data-sources/data-source

Posted by Peter Donald <pe...@apache.org>.

Hiya,

On Tue, 10 Sep 2002 09:35, Greg Steuck wrote:
> Could somebody explain the benefit of having data-sources element
> inside the configuration for
> o.a.a.cornerstone.blocks.datasource.DefaultDataSourceSelector?
>
> In my case it leads to a somewhat ugly configuration items similar to:
>
>   <data-sources>
>     <data-sources>
>       <data-source name="default"/>
>     </data-sources>
>   </data-sources>
>
> Am I missing something? If not, I attached a patch that removes
> that extra data-sources element...

Seems reasomable change ;) I applied the patch with slight modification. 
Instead of just ignoring the old configuration format it will detect it and 
issue a warning instead.

Could you download it and make sure it all still works properly ? :)

-- 
Cheers,

Peter Donald
-----------------------------------------------
|  If you turn on the light quickly enough,   |
|    you can see what the dark looks like.    |
----------------------------------------------- 


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>