You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/09/20 20:49:49 UTC
Change in asterixdb[master]: [NO ISSUE] Remove unused function from Parquet Azure
From Wael Alkowaileet <wa...@gmail.com>:
Wael Alkowaileet has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304 )
Change subject: [NO ISSUE] Remove unused function from Parquet Azure
......................................................................
[NO ISSUE] Remove unused function from Parquet Azure
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Remove emulator endpoint extraction method
Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
---
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/04/13304/1
diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
index 4d1311c..b2b667a 100644
--- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
+++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
@@ -116,11 +116,6 @@
return uri.substring(uri.indexOf("//") + "//".length());
}
- private String extractEndPointForEmulator(String uri) {
- String emulatorURI = extractEndPoint(uri);
- return emulatorURI.substring(0, emulatorURI.indexOf('/'));
- }
-
private static void appendFileURI(StringBuilder builder, String container, String endPoint, BlobItem file) {
builder.append(ExternalDataConstants.AzureBlob.HADOOP_AZURE_BLOB_PROTOCOL);
builder.append("://");
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
Gerrit-Change-Number: 13304
Gerrit-PatchSet: 1
Gerrit-Owner: Wael Alkowaileet <wa...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE] Remove unused function from Parquet Azure
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Wael Alkowaileet <wa...@gmail.com>:
Wael Alkowaileet has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304 )
Change subject: [NO ISSUE] Remove unused function from Parquet Azure
......................................................................
[NO ISSUE] Remove unused function from Parquet Azure
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Remove emulator endpoint extraction method
Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304
Reviewed-by: Hussain Towaileb <hu...@gmail.com>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Hussain Towaileb: Looks good to me, approved
Jenkins: Verified; Verified
Objections:
Anon. E. Moose #1000171: Violations found
diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
index 4d1311c..b2b667a 100644
--- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
+++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
@@ -116,11 +116,6 @@
return uri.substring(uri.indexOf("//") + "//".length());
}
- private String extractEndPointForEmulator(String uri) {
- String emulatorURI = extractEndPoint(uri);
- return emulatorURI.substring(0, emulatorURI.indexOf('/'));
- }
-
private static void appendFileURI(StringBuilder builder, String container, String endPoint, BlobItem file) {
builder.append(ExternalDataConstants.AzureBlob.HADOOP_AZURE_BLOB_PROTOCOL);
builder.append("://");
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
Gerrit-Change-Number: 13304
Gerrit-PatchSet: 2
Gerrit-Owner: Wael Alkowaileet <wa...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Wael Alkowaileet <wa...@gmail.com>
Gerrit-MessageType: merged
Change in asterixdb[master]: [NO ISSUE] Remove unused function from Parquet Azure
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Wael Alkowaileet <wa...@gmail.com>:
Wael Alkowaileet has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304 )
Change subject: [NO ISSUE] Remove unused function from Parquet Azure
......................................................................
[NO ISSUE] Remove unused function from Parquet Azure
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Remove emulator endpoint extraction method
Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
---
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/04/13304/1
diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
index 4d1311c..b2b667a 100644
--- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
+++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/parquet/AzureBlobParquetReaderFactory.java
@@ -116,11 +116,6 @@
return uri.substring(uri.indexOf("//") + "//".length());
}
- private String extractEndPointForEmulator(String uri) {
- String emulatorURI = extractEndPoint(uri);
- return emulatorURI.substring(0, emulatorURI.indexOf('/'));
- }
-
private static void appendFileURI(StringBuilder builder, String container, String endPoint, BlobItem file) {
builder.append(ExternalDataConstants.AzureBlob.HADOOP_AZURE_BLOB_PROTOCOL);
builder.append("://");
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
Gerrit-Change-Number: 13304
Gerrit-PatchSet: 1
Gerrit-Owner: Wael Alkowaileet <wa...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE] Remove unused function from Parquet Azure
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Hussain Towaileb <hu...@gmail.com>:
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304 )
Change subject: [NO ISSUE] Remove unused function from Parquet Azure
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
Gerrit-Change-Number: 13304
Gerrit-PatchSet: 1
Gerrit-Owner: Wael Alkowaileet <wa...@gmail.com>
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Mon, 20 Sep 2021 21:08:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE] Remove unused function from Parquet Azure
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304 )
Change subject: [NO ISSUE] Remove unused function from Parquet Azure
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/1X9acA1yWM1poaZH8 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
Gerrit-Change-Number: 13304
Gerrit-PatchSet: 1
Gerrit-Owner: Wael Alkowaileet <wa...@gmail.com>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Mon, 20 Sep 2021 20:59:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE] Remove unused function from Parquet Azure
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304 )
Change subject: [NO ISSUE] Remove unused function from Parquet Azure
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/12516/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13304
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I67a2459a22e3802eed8dc000f56dd7e941543295
Gerrit-Change-Number: 13304
Gerrit-PatchSet: 1
Gerrit-Owner: Wael Alkowaileet <wa...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Tue, 21 Sep 2021 01:14:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment