[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2109: IGNITE-19521 Rework units list command

["PakhomovAlexander (via GitHub)" <gi...@apache.org>]

PakhomovAlexander commented on code in PR #2109:
URL: https://github.com/apache/ignite-3/pull/2109#discussion_r1214089624


##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/call/unit/ItDeployUndeployCallsTest.java:
##########
@@ -92,19 +101,21 @@ void deployListStatusUndeploy() {
         // Then
         assertThat(deployOutput.hasError()).isFalse();
         assertThat(deployOutput.body()).isEqualTo(MessageUiComponent.from(UiElements.done()).render());
-        // And list is not empty
-        List<UnitStatusRecord> unisStatuses = listUnitCall.execute(urlInput).body();
-        assertThat(unisStatuses.size()).isEqualTo(1);
-        // And status is not empty
-        await().untilAsserted(() -> assertThat(unitStatusCall.execute(statusInput("test.id"))).isNotNull());
+
+        await().untilAsserted(() -> {
+            // And list is not empty
+            List<UnitStatusRecord> unisStatuses = listUnitCall.execute(listAllInput()).body();
+            assertThat(unisStatuses.size()).isEqualTo(1);
+            Assertions.assertThat(unisStatuses.get(0).versionToStatus()).containsExactly(entry("1.0.0", DEPLOYED));

Review Comment:
   Use static import here, please.



##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/call/unit/ItDeployUndeployCallsTest.java:
##########
@@ -208,17 +213,12 @@ void deployStatusCheck() {
         // Then
         assertThat(deployOutput.hasError()).isFalse();
         assertThat(deployOutput.body()).isEqualTo(MessageUiComponent.from(UiElements.done()).render());
-        // And list is not empty
+
         await().untilAsserted(() -> {
-            List<UnitStatusRecord> unisStatuses = listUnitCall.execute(urlInput).body();
+            // And list is not empty
+            List<UnitStatusRecord> unisStatuses = listUnitCall.execute(listAllInput()).body();

Review Comment:
   ```suggestion
               List<UnitStatusRecord> unitsStatuses = listUnitCall.execute(listAllInput()).body();
   ```



##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/call/unit/ItDeployUndeployCallsTest.java:
##########
@@ -208,17 +213,12 @@ void deployStatusCheck() {
         // Then
         assertThat(deployOutput.hasError()).isFalse();
         assertThat(deployOutput.body()).isEqualTo(MessageUiComponent.from(UiElements.done()).render());
-        // And list is not empty
+
         await().untilAsserted(() -> {
-            List<UnitStatusRecord> unisStatuses = listUnitCall.execute(urlInput).body();
+            // And list is not empty
+            List<UnitStatusRecord> unisStatuses = listUnitCall.execute(listAllInput()).body();
             assertThat(unisStatuses.size()).isEqualTo(1);
-            assertThat(unisStatuses.get(0).versionToStatus().size()).isEqualTo(1);
-            assertThat(unisStatuses.get(0).versionToStatus().get("1.1.0"))
-                    .isNotNull()
-                    .matches(deploymentStatus -> deploymentStatus == DEPLOYED);
-
-            // And status is not empty
-            assertThat(unitStatusCall.execute(statusInput("test.id"))).isNotNull();
+            Assertions.assertThat(unisStatuses.get(0).versionToStatus()).containsExactly(entry("1.1.0", DEPLOYED));

Review Comment:
   static import



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org