[GitHub] [pulsar-client-cpp] tongsucn commented on a diff in pull request #129: [improve] Add configuration to limit times of client's lookup redirection.

["tongsucn (via GitHub)" <gi...@apache.org>]

tongsucn commented on code in PR #129:
URL: https://github.com/apache/pulsar-client-cpp/pull/129#discussion_r1094042915


##########
include/pulsar/ClientConfiguration.h:
##########
@@ -64,25 +64,25 @@ class PULSAR_PUBLIC ClientConfiguration {
      *
      * @param timeout the timeout after which the operation will be considered as failed
      */
-    ClientConfiguration& setOperationTimeoutSeconds(int timeout);
+    ClientConfiguration& setOperationTimeoutSeconds(int32_t timeout);

Review Comment:
   I'll change them later this week



##########
include/pulsar/ClientConfiguration.h:
##########
@@ -64,25 +64,25 @@ class PULSAR_PUBLIC ClientConfiguration {
      *
      * @param timeout the timeout after which the operation will be considered as failed
      */
-    ClientConfiguration& setOperationTimeoutSeconds(int timeout);
+    ClientConfiguration& setOperationTimeoutSeconds(int32_t timeout);

Review Comment:
   I'll fix them later this week



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org