[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1423: minor fix and make align with float->float64

[GitBox <gi...@apache.org>]

liukun4515 commented on a change in pull request #1423:
URL: https://github.com/apache/arrow-datafusion/pull/1423#discussion_r765674632



##########
File path: datafusion/src/sql/planner.rs
##########
@@ -1989,10 +1989,10 @@ fn extract_possible_join_keys(
 pub fn convert_data_type(sql: &SQLDataType) -> Result<DataType> {
     match sql {
         SQLDataType::Boolean => Ok(DataType::Boolean),
-        SQLDataType::SmallInt(_display) => Ok(DataType::Int16),
-        SQLDataType::Int(_display) => Ok(DataType::Int32),
-        SQLDataType::BigInt(_display) => Ok(DataType::Int64),
-        SQLDataType::Float(_) => Ok(DataType::Float64),
+        SQLDataType::SmallInt(_) => Ok(DataType::Int16),
+        SQLDataType::Int(_) => Ok(DataType::Int32),
+        SQLDataType::BigInt(_) => Ok(DataType::Int64),
+        SQLDataType::Float(_) => Ok(DataType::Float32),

Review comment:
       The SQL FLOAT datatype is corresponding to the Arrow Float64.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org