You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "Chenjp (via GitHub)" <gi...@apache.org> on 2026/05/21 02:03:17 UTC
[PR] Fix implicit type‑conversion precision issues in equalsIgnoreCase [tomcat]
Chenjp opened a new pull request, #1010:
URL: https://github.com/apache/tomcat/pull/1010
See testcase,
```java
// bc ByteChunk bytes: Hello
Assert.assertTrue(bc.equalsIgnoreCase("heLLo"));
Assert.assertFalse(bc.equalsIgnoreCase("\u8a48\u8a65\u8a6c\u8a6c\u8a6f"));
```
Ascii.toLower(c) implicitly assume c<=0xff.
It is hard to exploit with this weakness. Now add an explicit check to improve robustness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix implicit type‑conversion precision issues in equalsIgnoreCase [tomcat]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf closed pull request #1010: Fix implicit type‑conversion precision issues in equalsIgnoreCase
URL: https://github.com/apache/tomcat/pull/1010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix implicit type‑conversion precision issues in equalsIgnoreCase [tomcat]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #1010:
URL: https://github.com/apache/tomcat/pull/1010#issuecomment-4521294523
Thanks for the PR. I've fixed this and a handful of similar issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org