You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by hsuanyi <gi...@git.apache.org> on 2015/12/02 16:57:53 UTC
[GitHub] drill pull request: DRILL-4147: Change UnionPrel's DrillDistributi...
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/288
DRILL-4147: Change UnionPrel's DrillDistributionTrait to be ANY to al…
…low Union-All to be done in parallel
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsuanyi/incubator-drill DRILL-4147
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit 9f31a4c04c2cb219237519070b35d5fae3010908
Author: Hsuan-Yi Chu <hs...@usc.edu>
Date: 2015-12-02T00:46:51Z
DRILL-4147: Change UnionPrel's DrillDistributionTrait to be ANY to allow Union-All to be done in parallel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4147: Change UnionPrel's DrillDistributi...
Posted by amansinha100 <gi...@git.apache.org>.
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/288#discussion_r47124992
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java ---
@@ -899,4 +900,35 @@ public void testUnionAllInWith() throws Exception {
.build()
.run();
}
+
+ @Test // see DRILL-4147
+ public void testUnionAllDistributedMode() throws Exception {
--- End diff --
Similar to this test, could you make the slice_target = 1 for all the other Union-All tests ? That will give additional coverage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---