[GitHub] [superset] ofekisr edited a comment on pull request #17407: refactor(TestChartApi): move chart data api tests into TestChartDataApi

[GitBox <gi...@apache.org>]

ofekisr edited a comment on pull request #17407:
URL: https://github.com/apache/superset/pull/17407#issuecomment-968355113


   mapping from the old test name (chartApiTest) to the new name in ChartDataApiTest
   
   test_chart_data_simple --> test_with_valid_qc__data_is_returned
   test_chart_data_get_no_query_context --> test_get_data_when_query_context_is_null
   test_chart_data_get === test_chart_data_get
   test_chart_data_applied_time_extras === test_chart_data_applied_time_extras
   test_chart_data_limit_offset --> test_with_row_limit_and_offset__row_limit_and_offset_were_applied
   test_chart_data_default_row_limit --> test_without_row_limit__row_count_as_default_row_limit
   test_chart_data_sql_max_row_limit --> test_with_row_limit_bigger_then_sql_max_row__rowcount_as_sql_max_row
   test_chart_data_sample_default_limit --> test_as_samples_without_row_limit__row_count_as_default_samples_row_limit
   test_chart_data_sample_custom_limit --> test_with_row_limit_as_samples__rowcount_as_row_limit
   test_chart_data_sql_max_row_sample_limit --> 
            test_as_samples_with_row_limit_bigger_then_sql_max_row__rowcount_as_sql_max_row
   test_chart_data_incorrect_result_type --> test_with_incorrect_result_type__400
   test_chart_data_incorrect_result_format --> test_with_incorrect_result_format__400
   test_chart_data_invalid_form_data --> test_with_invalid_payload__400
   test_chart_data_query_result_type --> test_with_query_result_type__200
   test_chart_data_csv_result_format --> test_with_csv_result_format
   test_chart_data_csv_result_format_permission_denined --> 
            test_with_csv_result_format_when_actor_not_permitted_for_csv__403
   test_chart_data_mixed_case_filter_op --> test_with_in_op_filter__data_is_returned
   test_chart_data_dttm_filter === test_chart_data_dttm_filter
   test_chart_data_prophet === test_chart_data_prophet
   test_chart_data_query_missing_filter --> test_with_query_result_type_and_non_existent_filter__filter_omitted
   test_chart_data_no_data --> test_with_filter_suppose_to_return_empty_data__no_data_returned
   test_chart_data_incorrect_request --> test_with_invalid_where_parameter__400
   test_chart_data_with_invalid_datasource --> test_with_invalid_datasource__400
   test_chart_data_with_invalid_enum_value --> test_with_invalid_time_range_endpoints_enum_value__400
   test_query_exec_not_allowed --> test_with_not_permitted_actor__401
   test_chart_data_jinja_filter_request --> 
            test_when_where_parameter_is_template_and_query_result_type__query_is_templated
   test_chart_data_async === test_chart_data_async
   test_chart_data_async_cached_sync_response === test_chart_data_async_cached_sync_response
   test_chart_data_async_results_type === test_chart_data_async_results_type
   test_chart_data_async_invalid_token === test_chart_data_async_invalid_token
   test_chart_data_cache === test_chart_data_cache
   test_chart_data_cache_run_failed === test_chart_data_cache_run_failed
   test_chart_data_cache_no_login === test_chart_data_cache_no_login
   test_chart_data_cache_key_error === test_chart_data_cache_key_error
   test_chart_data_annotations --> test_with_annotations_layers__annotations_data_returned
   test_chart_data_rowcount === test_chart_data_rowcount
   test_chart_data_timegrains --> test_with_timegrains_and_columns_result_types
   test_chart_data_series_limit --> test_with_series_limit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org