You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/10/20 21:07:05 UTC
Review Request 26951: Add dispatch and http request event counters to
Scheduler driver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1943
https://issues.apache.org/jira/browse/MESOS-1943
Repository: mesos-git
Description
-------
add dispatch and http request event counters to scheduler driver
Diffs
-----
src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
Diff: https://reviews.apache.org/r/26951/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 26951: Add dispatch and http request event
counters to Scheduler driver
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 21, 2014, 1:07 a.m., Ben Mahler wrote:
> > src/sched/sched.cpp, lines 1018-1021
> > <https://reviews.apache.org/r/26951/diff/1/?file=726110#file726110line1018>
> >
> > What's the point of exposing this one, there are no calls to route()..?
>
> Dominic Hamon wrote:
> For consistency with the Master event queue metrics.
>
> Dominic Hamon wrote:
> to think of it another way: if these metrics were exposed at the Process level (where they should be, if we can solve the dependency issue) then the Driver would have the http request metric. Does that help sway you?
When I've been thinking of them at the Process level, I had still been thinking of them as being opt-in. Otherwise, we might have some performance issues?
There would be a ton of anonymous processes (e.g. internal libprocess Processes, like HttpProxy, RouteProcess, etc.), or unnecessary processes (like tens of thousands of SlaveObserver processes) causing metrics to be really expensive.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/#review57507
-----------------------------------------------------------
On Oct. 20, 2014, 7:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26951/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 7:07 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1943
> https://issues.apache.org/jira/browse/MESOS-1943
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> add dispatch and http request event counters to scheduler driver
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
> src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
>
> Diff: https://reviews.apache.org/r/26951/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26951: Add dispatch and http request event
counters to Scheduler driver
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 21, 2014, 1:07 a.m., Ben Mahler wrote:
> >
Modulo the unnecessary http queue size metric, looks good!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/#review57507
-----------------------------------------------------------
On Oct. 20, 2014, 7:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26951/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 7:07 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1943
> https://issues.apache.org/jira/browse/MESOS-1943
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> add dispatch and http request event counters to scheduler driver
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
> src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
>
> Diff: https://reviews.apache.org/r/26951/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26951: Add dispatch and http request event
counters to Scheduler driver
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Oct. 20, 2014, 6:07 p.m., Ben Mahler wrote:
> > src/sched/sched.cpp, lines 1018-1021
> > <https://reviews.apache.org/r/26951/diff/1/?file=726110#file726110line1018>
> >
> > What's the point of exposing this one, there are no calls to route()..?
>
> Dominic Hamon wrote:
> For consistency with the Master event queue metrics.
to think of it another way: if these metrics were exposed at the Process level (where they should be, if we can solve the dependency issue) then the Driver would have the http request metric. Does that help sway you?
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/#review57507
-----------------------------------------------------------
On Oct. 20, 2014, 12:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26951/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 12:07 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1943
> https://issues.apache.org/jira/browse/MESOS-1943
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> add dispatch and http request event counters to scheduler driver
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
> src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
>
> Diff: https://reviews.apache.org/r/26951/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26951: Add dispatch and http request event counters to Scheduler driver
Posted by Benjamin Mahler <bm...@twitter.com.INVALID>.
Shouldn't we only expose meaningful metrics? Not sure whether users of the driver need consistent metrics vs master at the cost of having a meaningless one. Up to you.
Sent from my iPhone
> On Oct 21, 2014, at 9:46 AM, Dominic Hamon <dh...@twopensource.com> wrote:
>
>
>
>>> On Oct. 20, 2014, 6:07 p.m., Ben Mahler wrote:
>>> src/sched/sched.cpp, lines 1018-1021
>>> <https://reviews.apache.org/r/26951/diff/1/?file=726110#file726110line1018>
>>>
>>> What's the point of exposing this one, there are no calls to route()..?
>
> For consistency with the Master event queue metrics.
>
>
> - Dominic
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26951/#review57507
> -----------------------------------------------------------
>
>
>> On Oct. 20, 2014, 12:07 p.m., Dominic Hamon wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/26951/
>> -----------------------------------------------------------
>>
>> (Updated Oct. 20, 2014, 12:07 p.m.)
>>
>>
>> Review request for mesos and Vinod Kone.
>>
>>
>> Bugs: MESOS-1943
>> https://issues.apache.org/jira/browse/MESOS-1943
>>
>>
>> Repository: mesos-git
>>
>>
>> Description
>> -------
>>
>> add dispatch and http request event counters to scheduler driver
>>
>>
>> Diffs
>> -----
>>
>> src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
>> src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
>>
>> Diff: https://reviews.apache.org/r/26951/diff/
>>
>>
>> Testing
>> -------
>>
>> make check
>>
>>
>> Thanks,
>>
>> Dominic Hamon
>
Re: Review Request 26951: Add dispatch and http request event
counters to Scheduler driver
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Oct. 20, 2014, 6:07 p.m., Ben Mahler wrote:
> > src/sched/sched.cpp, lines 1018-1021
> > <https://reviews.apache.org/r/26951/diff/1/?file=726110#file726110line1018>
> >
> > What's the point of exposing this one, there are no calls to route()..?
For consistency with the Master event queue metrics.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/#review57507
-----------------------------------------------------------
On Oct. 20, 2014, 12:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26951/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 12:07 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1943
> https://issues.apache.org/jira/browse/MESOS-1943
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> add dispatch and http request event counters to scheduler driver
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
> src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
>
> Diff: https://reviews.apache.org/r/26951/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26951: Add dispatch and http request event
counters to Scheduler driver
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/#review57507
-----------------------------------------------------------
src/sched/sched.cpp
<https://reviews.apache.org/r/26951/#comment98227>
What's the point of exposing this one, there are no calls to route()..?
- Ben Mahler
On Oct. 20, 2014, 7:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26951/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 7:07 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1943
> https://issues.apache.org/jira/browse/MESOS-1943
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> add dispatch and http request event counters to scheduler driver
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
> src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
>
> Diff: https://reviews.apache.org/r/26951/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26951: Add dispatch and http request event
counters to Scheduler driver
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/#review57442
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26951]
All tests passed.
- Mesos ReviewBot
On Oct. 20, 2014, 7:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26951/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 7:07 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1943
> https://issues.apache.org/jira/browse/MESOS-1943
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> add dispatch and http request event counters to scheduler driver
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
> src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
>
> Diff: https://reviews.apache.org/r/26951/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26951: Add dispatch and http request event
counters to Scheduler driver
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/#review57503
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 20, 2014, 7:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26951/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 7:07 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1943
> https://issues.apache.org/jira/browse/MESOS-1943
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> add dispatch and http request event counters to scheduler driver
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
> src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
>
> Diff: https://reviews.apache.org/r/26951/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26951: Add dispatch event counters to Scheduler
driver
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26951/
-----------------------------------------------------------
(Updated Oct. 21, 2014, 1:39 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
removed http request counter
Summary (updated)
-----------------
Add dispatch event counters to Scheduler driver
Bugs: MESOS-1943
https://issues.apache.org/jira/browse/MESOS-1943
Repository: mesos-git
Description
-------
add dispatch and http request event counters to scheduler driver
Diffs (updated)
-----
src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8
src/tests/scheduler_tests.cpp d6a7867452d19cf1e65b780d0801cb4a0cd98e18
Diff: https://reviews.apache.org/r/26951/diff/
Testing
-------
make check
Thanks,
Dominic Hamon