You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2022/05/03 16:28:42 UTC
[kudu-CR] [master] KUDU-2671: Range specific hashing during table alter op.
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18485
Change subject: [master] KUDU-2671: Range specific hashing during table alter op.
......................................................................
[master] KUDU-2671: Range specific hashing during table alter op.
This commit has the proto file, master.proto, updated to reflect
the changes needed for having custom hash partitioning while
adding a new range to an existing table.
The AlterTableRequestPB has the new field to accommodate the
new change.
The reason for pushing this patch with just this change is to
unblock client side work while the server side work is being
done.
Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
---
M src/kudu/master/master.proto
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/18485/1
--
To view, visit http://gerrit.cloudera.org:8080/18485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Gerrit-Change-Number: 18485
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR] [master] KUDU-2671: Range specific hashing during table alter op.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18485 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op.
......................................................................
[master] KUDU-2671: Range specific hashing during table alter op.
This commit has the proto file, master.proto, updated to reflect
the changes needed for having custom hash partitioning while
adding a new range to an existing table.
The AlterTableRequestPB has the new field to accommodate the
new change.
The reason for pushing this patch with just this change is to
unblock client side work while the server side work is being
done.
Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Reviewed-on: http://gerrit.cloudera.org:8080/18485
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/master/master.proto
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Gerrit-Change-Number: 18485
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [master] KUDU-2671: Range specific hashing during table alter op.
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18485
to look at the new patch set (#3).
Change subject: [master] KUDU-2671: Range specific hashing during table alter op.
......................................................................
[master] KUDU-2671: Range specific hashing during table alter op.
This commit has the proto file, master.proto, updated to reflect
the changes needed for having custom hash partitioning while
adding a new range to an existing table.
The AlterTableRequestPB has the new field to accommodate the
new change.
The reason for pushing this patch with just this change is to
unblock client side work while the server side work is being
done.
Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
---
M src/kudu/master/master.proto
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/18485/3
--
To view, visit http://gerrit.cloudera.org:8080/18485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Gerrit-Change-Number: 18485
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [master] KUDU-2671: Range specific hashing during table alter op.
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18485 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op.
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Gerrit-Change-Number: 18485
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 May 2022 22:30:43 +0000
Gerrit-HasComments: No
[kudu-CR] [master] KUDU-2671: Range specific hashing during table alter op.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18485 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Gerrit-Change-Number: 18485
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 14:37:20 +0000
Gerrit-HasComments: No
[kudu-CR] [master] KUDU-2671: Range specific hashing during table alter op.
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18485
to look at the new patch set (#2).
Change subject: [master] KUDU-2671: Range specific hashing during table alter op.
......................................................................
[master] KUDU-2671: Range specific hashing during table alter op.
This commit has the proto file, master.proto, updated to reflect
the changes needed for having custom hash partitioning while
adding a new range to an existing table.
The AlterTableRequestPB has the new field to accommodate the
new change.
The reason for pushing this patch with just this change is to
unblock client side work while the server side work is being
done.
Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
---
M src/kudu/master/master.proto
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/18485/2
--
To view, visit http://gerrit.cloudera.org:8080/18485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Gerrit-Change-Number: 18485
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master] KUDU-2671: Range specific hashing during table alter op.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18485 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op.
......................................................................
Patch Set 1:
It seems the compilation failed:
9:29:23 kudu/master/master.proto:737:14: "HashBucketSchemaPB" is not defined.
09:29:23 CMakeFiles/Makefile2:17619: recipe for target 'src/kudu/master/CMakeFiles/kudu-master-master.proto.dir/all' failed
--
To view, visit http://gerrit.cloudera.org:8080/18485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Gerrit-Change-Number: 18485
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 May 2022 17:05:26 +0000
Gerrit-HasComments: No
[kudu-CR] [master] KUDU-2671: Range specific hashing during table alter op.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18485 )
Change subject: [master] KUDU-2671: Range specific hashing during table alter op.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18485/2/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/18485/2/src/kudu/master/master.proto@737
PS2, Line 737: custom_hash_schema_ranges
This is just a hash bucket schema, not ranges per se, right? The range is specified by the 'range_bounds' field in this message, IIUC. If so, maybe rename this to be 'custom_hash_schema'?
--
To view, visit http://gerrit.cloudera.org:8080/18485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec5566ea8f3e49d00dcb6964b3d17c4be0504eb
Gerrit-Change-Number: 18485
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 May 2022 01:48:42 +0000
Gerrit-HasComments: Yes