[jira] [Commented] (DRILL-1519) Concurrent access to WorkEventBus#getOrCreateFragmentManager leaks memory.

["Parth Chandra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166433#comment-14166433 ] 

Parth Chandra commented on DRILL-1519:
--------------------------------------

I noticed the same issue while looking into why the fragment memory limit implementation was over estimating the number of running fragments. I have a patch ready, and will send it out for review. See DRILL-1504. 

> Concurrent access to WorkEventBus#getOrCreateFragmentManager leaks memory.
> --------------------------------------------------------------------------
>
>                 Key: DRILL-1519
>                 URL: https://issues.apache.org/jira/browse/DRILL-1519
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Hanifi Gunes
>            Assignee: Hanifi Gunes
>
> WorkEventBus uses a ConcurrentHashMap to ensure there is one and only one FragmentManager corresponding to each unique FragmentHandle. The method creates a FragmentManager that reserves some initial memory if a thread observes that it is not in the map. However, in case of concurrent access, we still need to clean up after if multiple threads observe that FragmentManager does not exist and create multiple FragmentManagers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)