You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/01/23 05:53:47 UTC
[Bug 4098] New: disable separate rule functions during normal use
http://bugzilla.spamassassin.org/show_bug.cgi?id=4098
Summary: disable separate rule functions during normal use
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: enhancement
Priority: P5
Component: Rules
AssignedTo: dev@spamassassin.apache.org
ReportedBy: felicity@kluge.net
During lunch at the Spam Conference, Jon Mitchell was mentioning that he was
able to get extra performance out of SA by changing from the "each rule is a
subroutine" into just calling the rules in one function.
The rules in each function thing is useful for profiling, but all of the
function calls will obviously slow us down during normal operation. It's not
clear how much of a slow down is caused though, so I'd like to do some testing
to find out. I'd have to imagine it was at least a few percent, otherwise it
probably wouldn't have come up.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4098] disable separate rule functions during normal use
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4098
quinlan@pathname.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.1.0 |3.2.0
------- Additional Comments From quinlan@pathname.com 2005-04-10 01:58 -------
I think this is worth doing, but without a patch, I'm moving to 3.2.0.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4098] disable separate rule functions during normal use
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4098
felicity@kluge.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Future |3.1.0
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4098] disable separate rule functions during normal use
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4098
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2006-09-05 14:55 -------
I did this last week ;) in conjunction with some code to reduce the overhead of
'tflags multiple' rules, it provided a 7% speedup on a small mixed test corpus I
use to measure performance.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4098] disable separate rule functions during normal use
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4098
------- Additional Comments From jm@jmason.org 2005-01-24 10:23 -------
you know, I forgot all about that ;) Craig did that ages ago, in order to
allow profiling of individual rules, and we accepted that the speed hit was
worth the profilability. but we can just change the code now to dynamically
select between the profiling (one sub per rule) vs speed (all rules in one sub)
versions at runtime, possibly based on the setting of -D.
'I've tested it recently. It's only about 0.6% overall when changing the
do head tests function to do this (and that's removing both the
subrouting call *and* the if tests against the rule scores). Not a huge
improvement.'
are you sure about that? ISTR it being quite a bit more last time I looked.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4098] disable separate rule functions during normal use
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4098
------- Additional Comments From quinlan@pathname.com 2005-01-22 23:57 -------
Subject: Re: New: disable separate rule functions during normal use
> I'd have to imagine it was at least a few percent, otherwise it
> probably wouldn't have come up.
I've tested it recently. It's only about 0.6% overall when changing the
do head tests function to do this (and that's removing both the
subrouting call *and* the if tests against the rule scores). Not a huge
improvement.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.