You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Hadrian Zbarcea <hz...@gmail.com> on 2009/08/01 01:02:36 UTC

GPL licensed code in Camel

Hi,

Ohloh (https://www.ohloh.net/p/camel/analyses/latest) 2 GPL and 2 LGPL  
files or dependencies in the camel distro and I cannot figure out  
which ones they are.  Any ideas?

Hadrian

Re: GPL licensed code in Camel

Posted by Hadrian Zbarcea <hz...@gmail.com>.
Oisin, you're a treasure chest :).

I added my own comment to the thread you referred me to.  I was aware  
of the comments, but assumed a more likely, and more damaging GPL  
dependency.

Btw, ./components/camel-xstream/pom.xml has this:

     <dependency>
       <groupId>com.thoughtworks.xstream</groupId>
       <artifactId>xstream</artifactId>
       <exclusions>
         <exclusion>
           <!-- xom is an optional dependency of xstream. Its also
                LGPL, so its really not ASF compatible. -->
           <groupId>xom</groupId>
           <artifactId>xom</artifactId>
         </exclusion>
       </exclusions>
     </dependency>


Thanks,
Hadrian



On Jul 31, 2009, at 7:25 PM, Oisin Hurley wrote:

> Hi Hadrian
>
>> Ohloh (https://www.ohloh.net/p/camel/analyses/latest) 2 GPL and 2  
>> LGPL files
>> or dependencies in the camel distro and I cannot figure out which  
>> ones they
>> are.  Any ideas?
>
> Ohloh has been criticised for naive license detection in the
> past  [0].  If you check the page that details the license detection
> approach [1], you will see that checking Java comments for uses
> of 'GPL'  is a core approach.
>
> Taking a look at
>
> components/camel-sql/src/test/java/org/apache/camel/component/sql/ 
> SqlDataSourceRefTest.java
>
> there is a comment
>
>        // send the query to direct that will route it to the sql
> where we will execute the query
>        // and bind the parameters with the data from the body. The
> body only contains one value
>        // in this case (GPL) but if we should use multi values then
> the body will be iterated
>        // so we could supply a List<String> instead containing each
> binding value.
>
> Notice the GPL in the comment? This could set off the Ohloh license
> detection to note a GPL-licensed file even though the file has an ASL
> header.
>
> This Ohloh report could potentially be damaging for Camel adoption,
> even though it is incorrect...it might be useful to zark the matches
> in the code that could be causing trouble and get Ohloh to refresh
> (e.g. change the GPL string to something else).
>
> Or if someone has a blackduck report hanging around or something
> like that they could share...
>
> cheers
>   --oh
>
> [0] https://www.ohloh.net/forums/11/topics/3160
> [1] https://www.ohloh.net/wiki/project_licenses

Re: GPL licensed code in Camel

Posted by Oisin Hurley <oi...@gmail.com>.
Hi Hadrian

> Ohloh (https://www.ohloh.net/p/camel/analyses/latest) 2 GPL and 2 LGPL files
> or dependencies in the camel distro and I cannot figure out which ones they
> are.  Any ideas?

Ohloh has been criticised for naive license detection in the
past  [0].  If you check the page that details the license detection
approach [1], you will see that checking Java comments for uses
of 'GPL'  is a core approach.

Taking a look at

components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlDataSourceRefTest.java

there is a comment

        // send the query to direct that will route it to the sql
where we will execute the query
        // and bind the parameters with the data from the body. The
body only contains one value
        // in this case (GPL) but if we should use multi values then
the body will be iterated
        // so we could supply a List<String> instead containing each
binding value.

Notice the GPL in the comment? This could set off the Ohloh license
detection to note a GPL-licensed file even though the file has an ASL
header.

This Ohloh report could potentially be damaging for Camel adoption,
even though it is incorrect...it might be useful to zark the matches
in the code that could be causing trouble and get Ohloh to refresh
(e.g. change the GPL string to something else).

Or if someone has a blackduck report hanging around or something
like that they could share...

 cheers
   --oh

[0] https://www.ohloh.net/forums/11/topics/3160
[1] https://www.ohloh.net/wiki/project_licenses