You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/26 22:12:02 UTC
[GitHub] [superset] samtfm opened a new pull request #13827: feat: add descriptions to report emails
samtfm opened a new pull request #13827:
URL: https://github.com/apache/superset/pull/13827
### SUMMARY
Adds the report description to the report email body
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfe990d) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.36%`.
> The diff coverage is `89.55%`.
> :exclamation: Current head dfe990d differs from pull request most recent head 5443ace. Consider uploading reports for the commit 5443ace to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.17% +0.36%
==========================================
Files 934 935 +1
Lines 47249 47407 +158
Branches 5892 5933 +41
==========================================
+ Hits 36294 36588 +294
+ Misses 10808 10675 -133
+ Partials 147 144 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.69% <88.46%> (+2.60%)` | :arrow_up: |
| hive | `80.29% <91.17%> (?)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `80.30% <91.17%> (?)` | |
| python | `80.77% <91.17%> (+0.21%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.99% <33.33%> (-21.65%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <50.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.21% <75.00%> (-2.42%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `93.10% <90.00%> (+2.62%)` | :arrow_up: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `85.18% <100.00%> (-0.27%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `89.47% <100.00%> (+0.58%)` | :arrow_up: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `92.85% <100.00%> (ø)` | |
| ... and [67 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...5443ace](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.05%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 79.15% -0.06%
==========================================
Files 936 936
Lines 47408 47431 +23
Branches 5940 5938 -2
==========================================
- Hits 37554 37544 -10
- Misses 9727 9761 +34
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <100.00%> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.79% <93.93%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <93.93%> (+0.21%)` | :arrow_up: |
| presto | `?` | |
| python | `80.90% <93.93%> (-0.25%)` | :arrow_down: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.25%`.
> The diff coverage is `71.53%`.
> :exclamation: Current head 16db416 differs from pull request most recent head 5443ace. Consider uploading reports for the commit 5443ace to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.07% +0.25%
==========================================
Files 934 938 +4
Lines 47249 47568 +319
Branches 5892 6021 +129
==========================================
+ Hits 36294 36661 +367
+ Misses 10808 10760 -48
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <59.67%> (+2.93%)` | :arrow_up: |
| mysql | `80.60% <86.36%> (+0.02%)` | :arrow_up: |
| postgres | `80.63% <86.36%> (+0.15%)` | :arrow_up: |
| python | `80.72% <86.36%> (+0.15%)` | :arrow_up: |
| sqlite | `80.19% <86.36%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (ø)` | |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `69.64% <38.88%> (-19.25%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `82.92% <50.00%> (-9.94%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `71.08% <53.57%> (-14.38%)` | :arrow_down: |
| ... and [65 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...5443ace](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (9e49b0c) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `0.37%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head 9e49b0c differs from pull request most recent head 667374b. Consider uploading reports for the commit 667374b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 78.18% -0.38%
==========================================
Files 935 935
Lines 47374 47374
Branches 5971 5973 +2
==========================================
- Hits 37221 37041 -180
- Misses 10010 10190 +180
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <ø> (-0.01%)` | :arrow_down: |
| hive | `80.27% <80.00%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| python | `80.27% <80.00%> (-0.72%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.35% <0.00%> (-9.81%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...667374b](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-815054740
@samtfm looks like master is green, a rebase will likely solve your build issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (e2d4562) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 76.81% 76.80% -0.01%
==========================================
Files 934 935 +1
Lines 47249 47269 +20
Branches 5892 5892
==========================================
+ Hits 36294 36305 +11
- Misses 10808 10817 +9
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `80.63% <80.00%> (+0.15%)` | :arrow_up: |
| python | `80.68% <80.00%> (+0.11%)` | :arrow_up: |
| sqlite | `80.19% <80.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.44% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.83% <100.00%> (+0.18%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.28% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.22% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.30% <0.00%> (ø)` | |
| [superset/utils/csv.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY3N2LnB5) | `100.00% <0.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...e2d4562](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (6004198) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.28%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 6004198 differs from pull request most recent head 82a2455. Consider uploading reports for the commit 82a2455 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 78.92% -0.29%
==========================================
Files 936 936
Lines 47408 47409 +1
Branches 5940 5940
==========================================
- Hits 37554 37418 -136
- Misses 9727 9864 +137
Partials 127 127
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.60% <80.00%> (-0.55%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...82a2455](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.19%`.
> The diff coverage is `71.53%`.
> :exclamation: Current head 16db416 differs from pull request most recent head 5443ace. Consider uploading reports for the commit 5443ace to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.00% +0.19%
==========================================
Files 934 938 +4
Lines 47249 47540 +291
Branches 5892 6021 +129
==========================================
+ Hits 36294 36609 +315
+ Misses 10808 10784 -24
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <59.67%> (+2.93%)` | :arrow_up: |
| mysql | `80.60% <86.36%> (+0.02%)` | :arrow_up: |
| postgres | `?` | |
| python | `80.60% <86.36%> (+0.03%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <ø> (-0.05%)` | :arrow_down: |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (ø)` | |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `69.64% <38.88%> (-19.25%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `82.92% <50.00%> (-9.94%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `71.08% <53.57%> (-14.38%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...5443ace](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (d70523a) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.16%`.
> The diff coverage is `91.03%`.
> :exclamation: Current head d70523a differs from pull request most recent head 1145f97. Consider uploading reports for the commit 1145f97 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 79.04% -0.17%
==========================================
Files 936 940 +4
Lines 47408 47598 +190
Branches 5940 5979 +39
==========================================
+ Hits 37554 37624 +70
- Misses 9727 9848 +121
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.74% <90.14%> (+0.16%)` | :arrow_up: |
| postgres | `80.77% <90.14%> (+0.16%)` | :arrow_up: |
| presto | `?` | |
| python | `80.85% <90.14%> (-0.30%)` | :arrow_down: |
| sqlite | `80.37% <90.14%> (+0.20%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `41.02% <ø> (ø)` | |
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `50.00% <ø> (-30.96%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.86% <ø> (+0.74%)` | :arrow_up: |
| ... and [58 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...1145f97](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (6004198) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.26%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 6004198 differs from pull request most recent head 82a2455. Consider uploading reports for the commit 82a2455 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 78.95% -0.27%
==========================================
Files 936 936
Lines 47408 47409 +1
Branches 5940 5940
==========================================
- Hits 37554 37430 -124
- Misses 9727 9852 +125
Partials 127 127
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.57% <80.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.65% <80.00%> (-0.50%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...82a2455](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfe990d) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.33%`.
> The diff coverage is `89.55%`.
> :exclamation: Current head dfe990d differs from pull request most recent head e2d4562. Consider uploading reports for the commit e2d4562 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.14% +0.33%
==========================================
Files 934 935 +1
Lines 47249 47408 +159
Branches 5892 5933 +41
==========================================
+ Hits 36294 36574 +280
+ Misses 10808 10690 -118
+ Partials 147 144 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.69% <88.46%> (+2.60%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.65% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.99% <33.33%> (-21.65%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <66.66%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.66% <75.00%> (+0.03%)` | :arrow_up: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `93.10% <90.00%> (+2.62%)` | :arrow_up: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `85.18% <100.00%> (-0.27%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `89.47% <100.00%> (+0.58%)` | :arrow_up: |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...e2d4562](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.34%`.
> The diff coverage is `71.53%`.
> :exclamation: Current head 16db416 differs from pull request most recent head a5261fa. Consider uploading reports for the commit a5261fa to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.15% +0.34%
==========================================
Files 934 938 +4
Lines 47249 47568 +319
Branches 5892 6021 +129
==========================================
+ Hits 36294 36703 +409
+ Misses 10808 10718 -90
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <59.67%> (+2.93%)` | :arrow_up: |
| mysql | `80.60% <86.36%> (+0.02%)` | :arrow_up: |
| postgres | `80.63% <86.36%> (+0.15%)` | :arrow_up: |
| presto | `80.30% <86.36%> (?)` | |
| python | `80.88% <86.36%> (+0.32%)` | :arrow_up: |
| sqlite | `80.19% <86.36%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (ø)` | |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `69.64% <38.88%> (-19.25%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `82.92% <50.00%> (-9.94%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `71.08% <53.57%> (-14.38%)` | :arrow_down: |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...a5261fa](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #13827:
URL: https://github.com/apache/superset/pull/13827#discussion_r603943163
##########
File path: superset/reports/notifications/email.py
##########
@@ -70,9 +70,11 @@ def _get_content(self) -> EmailContent:
image = {msgid: self._content.screenshot.image}
body = __(
"""
+ <p>%(description)s</p>
Review comment:
@junlincc ^^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **decrease** coverage by `0.50%`.
> The diff coverage is `71.53%`.
> :exclamation: Current head 16db416 differs from pull request most recent head 5443ace. Consider uploading reports for the commit 5443ace to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 76.81% 76.30% -0.51%
==========================================
Files 934 938 +4
Lines 47249 47540 +291
Branches 5892 6021 +129
==========================================
- Hits 36294 36276 -18
- Misses 10808 11101 +293
- Partials 147 163 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.40% <59.67%> (+0.31%)` | :arrow_up: |
| mysql | `80.60% <86.36%> (+0.02%)` | :arrow_up: |
| postgres | `?` | |
| python | `80.60% <86.36%> (+0.03%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <ø> (-0.05%)` | :arrow_down: |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (ø)` | |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `69.64% <38.88%> (-19.25%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `82.92% <50.00%> (-9.94%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `71.08% <53.57%> (-14.38%)` | :arrow_down: |
| ... and [99 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...5443ace](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (f85bb82) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `1.29%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head f85bb82 differs from pull request most recent head a7d9da5. Consider uploading reports for the commit a7d9da5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 77.27% -1.30%
==========================================
Files 935 935
Lines 47374 47375 +1
Branches 5971 5973 +2
==========================================
- Hits 37221 36610 -611
- Misses 10010 10606 +596
- Partials 143 159 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.19% <ø> (-7.86%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.56% <80.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| python | `80.68% <80.00%> (-0.31%)` | :arrow_down: |
| sqlite | `80.16% <80.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...a7d9da5](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (f85bb82) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `0.16%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head f85bb82 differs from pull request most recent head a7d9da5. Consider uploading reports for the commit a7d9da5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 78.40% -0.17%
==========================================
Files 935 935
Lines 47374 47376 +2
Branches 5971 5973 +2
==========================================
- Hits 37221 37145 -76
- Misses 10010 10088 +78
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <ø> (-0.01%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.56% <80.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| python | `80.68% <80.00%> (-0.31%)` | :arrow_down: |
| sqlite | `80.16% <80.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...a7d9da5](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfe990d) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.09%`.
> The diff coverage is `92.30%`.
> :exclamation: Current head dfe990d differs from pull request most recent head e2d4562. Consider uploading reports for the commit e2d4562 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 76.90% +0.09%
==========================================
Files 934 935 +1
Lines 47249 47278 +29
Branches 5892 5883 -9
==========================================
+ Hits 36294 36361 +67
+ Misses 10808 10767 -41
- Partials 147 150 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.15% <100.00%> (+5.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.65% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <66.66%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.66% <75.00%> (+0.03%)` | :arrow_up: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `93.10% <90.00%> (+2.62%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `68.64% <100.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `85.18% <100.00%> (-0.27%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `89.47% <100.00%> (+0.58%)` | :arrow_up: |
| ... and [38 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...e2d4562](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (9e49b0c) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `0.87%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 9e49b0c differs from pull request most recent head 667374b. Consider uploading reports for the commit 667374b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 77.69% -0.88%
==========================================
Files 935 935
Lines 47374 47374
Branches 5971 5973 +2
==========================================
- Hits 37221 36807 -414
- Misses 10010 10406 +396
- Partials 143 161 +18
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.66% <ø> (-5.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <100.00%> (ø)` | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| ... and [61 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...667374b](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **increase** coverage by `0.10%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 79.21% 79.31% +0.10%
==========================================
Files 936 936
Lines 47408 47431 +23
Branches 5940 5938 -2
==========================================
+ Hits 37554 37621 +67
+ Misses 9727 9684 -43
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <100.00%> (+0.01%)` | :arrow_up: |
| hive | `80.49% <93.93%> (+0.21%)` | :arrow_up: |
| mysql | `80.79% <93.93%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <93.93%> (+0.21%)` | :arrow_up: |
| presto | `?` | |
| python | `81.21% <93.93%> (+0.06%)` | :arrow_up: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (9e49b0c) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `1.02%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head 9e49b0c differs from pull request most recent head 82a2455. Consider uploading reports for the commit 82a2455 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 78.18% -1.03%
==========================================
Files 936 935 -1
Lines 47408 47374 -34
Branches 5940 5973 +33
==========================================
- Hits 37554 37041 -513
- Misses 9727 10190 +463
- Partials 127 143 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <ø> (-0.01%)` | :arrow_down: |
| hive | `80.27% <80.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.27% <80.00%> (-0.88%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | `0.00% <0.00%> (-91.67%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [50 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...82a2455](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **decrease** coverage by `0.05%`.
> The diff coverage is `83.50%`.
> :exclamation: Current head 16db416 differs from pull request most recent head 5443ace. Consider uploading reports for the commit 5443ace to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 76.81% 76.76% -0.06%
==========================================
Files 934 935 +1
Lines 47249 47248 -1
Branches 5892 5892
==========================================
- Hits 36294 36269 -25
- Misses 10808 10832 +24
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `80.60% <86.36%> (+0.02%)` | :arrow_up: |
| postgres | `?` | |
| python | `80.60% <86.36%> (+0.03%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <ø> (-0.05%)` | :arrow_down: |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `76.97% <20.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `85.45% <73.33%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.66% <75.00%> (+0.03%)` | :arrow_up: |
| ... and [43 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...5443ace](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (6004198) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.09%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 6004198 differs from pull request most recent head 82a2455. Consider uploading reports for the commit 82a2455 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 79.11% -0.10%
==========================================
Files 936 936
Lines 47408 47409 +1
Branches 5940 5940
==========================================
- Hits 37554 37509 -45
- Misses 9727 9773 +46
Partials 127 127
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.28% <80.00%> (+<0.01%)` | :arrow_up: |
| mysql | `80.57% <80.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.96% <80.00%> (-0.19%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.88% <0.00%> (-5.43%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.68%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...82a2455](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (e2d4562) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.01%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 76.82% +0.01%
==========================================
Files 934 935 +1
Lines 47249 47269 +20
Branches 5892 5892
==========================================
+ Hits 36294 36315 +21
+ Misses 10808 10807 -1
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `80.60% <80.00%> (+0.01%)` | :arrow_up: |
| postgres | `80.63% <80.00%> (+0.15%)` | :arrow_up: |
| python | `80.71% <80.00%> (+0.15%)` | :arrow_up: |
| sqlite | `80.19% <80.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.44% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.83% <100.00%> (+0.18%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.30% <0.00%> (ø)` | |
| [superset/utils/csv.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY3N2LnB5) | `100.00% <0.00%> (ø)` | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.43% <0.00%> (+0.02%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.74% <0.00%> (+0.03%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.66% <0.00%> (+0.03%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...e2d4562](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.08%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 79.13% -0.09%
==========================================
Files 936 936
Lines 47408 47431 +23
Branches 5940 5938 -2
==========================================
- Hits 37554 37534 -20
- Misses 9727 9771 +44
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.82% <93.93%> (+0.21%)` | :arrow_up: |
| presto | `?` | |
| python | `80.86% <93.93%> (-0.29%)` | :arrow_down: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (f85bb82) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `0.16%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head f85bb82 differs from pull request most recent head 667374b. Consider uploading reports for the commit 667374b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 78.40% -0.17%
==========================================
Files 935 935
Lines 47374 47376 +2
Branches 5971 5973 +2
==========================================
- Hits 37221 37145 -76
- Misses 10010 10088 +78
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <ø> (-0.01%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.56% <80.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| python | `80.68% <80.00%> (-0.31%)` | :arrow_down: |
| sqlite | `80.16% <80.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...667374b](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.48%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 78.72% -0.49%
==========================================
Files 936 936
Lines 47408 47431 +23
Branches 5940 5938 -2
==========================================
- Hits 37554 37340 -214
- Misses 9727 9948 +221
- Partials 127 143 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.06% <100.00%> (-2.99%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.79% <93.93%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <93.93%> (+0.21%)` | :arrow_up: |
| presto | `?` | |
| python | `80.90% <93.93%> (-0.25%)` | :arrow_down: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.05%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 79.15% -0.06%
==========================================
Files 936 936
Lines 47408 47431 +23
Branches 5940 5938 -2
==========================================
- Hits 37554 37544 -10
- Misses 9727 9761 +34
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.79% <93.93%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <93.93%> (+0.21%)` | :arrow_up: |
| presto | `?` | |
| python | `80.90% <93.93%> (-0.25%)` | :arrow_down: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfe990d) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.10%`.
> The diff coverage is `89.55%`.
> :exclamation: Current head dfe990d differs from pull request most recent head e2d4562. Consider uploading reports for the commit e2d4562 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 76.92% +0.10%
==========================================
Files 934 935 +1
Lines 47249 47407 +158
Branches 5892 5933 +41
==========================================
+ Hits 36294 36467 +173
+ Misses 10808 10796 -12
+ Partials 147 144 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.69% <88.46%> (+2.60%)` | :arrow_up: |
| hive | `80.29% <91.17%> (?)` | |
| mysql | `?` | |
| postgres | `?` | |
| python | `80.29% <91.17%> (-0.27%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.99% <33.33%> (-21.65%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <50.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.10% <75.00%> (-3.53%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `93.10% <90.00%> (+2.62%)` | :arrow_up: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `85.18% <100.00%> (-0.27%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `89.47% <100.00%> (+0.58%)` | :arrow_up: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `92.85% <100.00%> (ø)` | |
| ... and [69 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...e2d4562](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (9e49b0c) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 9e49b0c differs from pull request most recent head 667374b. Consider uploading reports for the commit 667374b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 78.56% 78.65% +0.08%
==========================================
Files 935 935
Lines 47374 47375 +1
Branches 5971 5973 +2
==========================================
+ Hits 37221 37261 +40
+ Misses 10010 9971 -39
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <100.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...667374b](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (d70523a) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **increase** coverage by `0.00%`.
> The diff coverage is `91.47%`.
> :exclamation: Current head d70523a differs from pull request most recent head 1145f97. Consider uploading reports for the commit 1145f97 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
========================================
Coverage 79.21% 79.22%
========================================
Files 936 940 +4
Lines 47408 47598 +190
Branches 5940 5979 +39
========================================
+ Hits 37554 37708 +154
- Misses 9727 9764 +37
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <60.00%> (+0.01%)` | :arrow_up: |
| hive | `80.47% <90.64%> (+0.19%)` | :arrow_up: |
| mysql | `80.74% <90.14%> (+0.16%)` | :arrow_up: |
| postgres | `80.77% <90.14%> (+0.16%)` | :arrow_up: |
| presto | `?` | |
| python | `81.18% <90.64%> (+0.03%)` | :arrow_up: |
| sqlite | `80.37% <90.14%> (+0.20%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `41.02% <ø> (ø)` | |
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `50.00% <ø> (-30.96%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.86% <ø> (+0.74%)` | :arrow_up: |
| ... and [54 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...1145f97](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (f85bb82) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `0.45%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head f85bb82 differs from pull request most recent head a7d9da5. Consider uploading reports for the commit a7d9da5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 78.11% -0.46%
==========================================
Files 935 935
Lines 47374 47376 +2
Branches 5971 5973 +2
==========================================
- Hits 37221 37006 -215
- Misses 10010 10223 +213
- Partials 143 147 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| python | `80.64% <80.00%> (-0.35%)` | :arrow_down: |
| sqlite | `80.16% <80.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `70.17% <0.00%> (-19.30%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...a7d9da5](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfe990d) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.36%`.
> The diff coverage is `89.55%`.
> :exclamation: Current head dfe990d differs from pull request most recent head e2d4562. Consider uploading reports for the commit e2d4562 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.17% +0.36%
==========================================
Files 934 935 +1
Lines 47249 47407 +158
Branches 5892 5933 +41
==========================================
+ Hits 36294 36588 +294
+ Misses 10808 10675 -133
+ Partials 147 144 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.69% <88.46%> (+2.60%)` | :arrow_up: |
| hive | `80.29% <91.17%> (?)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `80.30% <91.17%> (?)` | |
| python | `80.77% <91.17%> (+0.21%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.99% <33.33%> (-21.65%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <50.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.21% <75.00%> (-2.42%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `93.10% <90.00%> (+2.62%)` | :arrow_up: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `85.18% <100.00%> (-0.27%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `89.47% <100.00%> (+0.58%)` | :arrow_up: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `92.85% <100.00%> (ø)` | |
| ... and [67 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...e2d4562](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (f85bb82) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `0.71%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head f85bb82 differs from pull request most recent head a7d9da5. Consider uploading reports for the commit a7d9da5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 77.85% -0.72%
==========================================
Files 935 935
Lines 47374 47349 -25
Branches 5971 5973 +2
==========================================
- Hits 37221 36863 -358
- Misses 10010 10339 +329
- Partials 143 147 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| python | `80.16% <80.00%> (-0.83%)` | :arrow_down: |
| sqlite | `80.16% <80.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [49 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...a7d9da5](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (d70523a) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.19%`.
> The diff coverage is `91.03%`.
> :exclamation: Current head d70523a differs from pull request most recent head 1145f97. Consider uploading reports for the commit 1145f97 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 79.01% -0.20%
==========================================
Files 936 940 +4
Lines 47408 47571 +163
Branches 5940 5979 +39
==========================================
+ Hits 37554 37588 +34
- Misses 9727 9857 +130
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.76% <90.14%> (+0.15%)` | :arrow_up: |
| presto | `?` | |
| python | `80.80% <90.14%> (-0.35%)` | :arrow_down: |
| sqlite | `80.37% <90.14%> (+0.20%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `41.02% <ø> (ø)` | |
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `50.00% <ø> (-30.96%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.86% <ø> (+0.74%)` | :arrow_up: |
| ... and [67 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...1145f97](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] samtfm commented on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
samtfm commented on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-814386414
> LGTM once CI is green.
It looks like the failing python test `tests/datasets/api_tests.py::TestDatasetApi::test_get_dataset_distinct_schema` is also failing on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-815308090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-813568481
@samtfm you may want to rebase or merge from master - there are some conflicts here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.23%`.
> The diff coverage is `71.53%`.
> :exclamation: Current head 16db416 differs from pull request most recent head 5443ace. Consider uploading reports for the commit 5443ace to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.05% +0.23%
==========================================
Files 934 938 +4
Lines 47249 47568 +319
Branches 5892 6021 +129
==========================================
+ Hits 36294 36652 +358
+ Misses 10808 10769 -39
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <59.67%> (+2.93%)` | :arrow_up: |
| mysql | `80.60% <86.36%> (+0.02%)` | :arrow_up: |
| postgres | `80.63% <86.36%> (+0.15%)` | :arrow_up: |
| python | `80.68% <86.36%> (+0.11%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (ø)` | |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `69.64% <38.88%> (-19.25%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `82.92% <50.00%> (-9.94%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `71.08% <53.57%> (-14.38%)` | :arrow_down: |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...5443ace](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] samtfm commented on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
samtfm commented on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-815107257
I was getting failures running this test on my local master, but I'll try rebasing in case that was some local anomaly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (6004198) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.29%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 6004198 differs from pull request most recent head 82a2455. Consider uploading reports for the commit 82a2455 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 78.91% -0.30%
==========================================
Files 936 936
Lines 47408 47382 -26
Branches 5940 5940
==========================================
- Hits 37554 37392 -162
- Misses 9727 9863 +136
Partials 127 127
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.59% <80.00%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.59% <80.00%> (-0.56%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...82a2455](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `1.40%`.
> The diff coverage is `66.66%`.
> :exclamation: Current head 16db416 differs from pull request most recent head a7d9da5. Consider uploading reports for the commit a7d9da5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 77.15% -1.41%
==========================================
Files 935 938 +3
Lines 47374 47568 +194
Branches 5971 6021 +50
==========================================
- Hits 37221 36703 -518
- Misses 10010 10718 +708
- Partials 143 147 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <ø> (-0.03%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.60% <66.66%> (+0.03%)` | :arrow_up: |
| postgres | `80.63% <66.66%> (+0.03%)` | :arrow_up: |
| presto | `80.30% <66.66%> (?)` | |
| python | `80.88% <66.66%> (-0.11%)` | :arrow_down: |
| sqlite | `80.19% <66.66%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (-2.13%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (-1.59%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.58% <100.00%> (+0.35%)` | :arrow_up: |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.83% <100.00%> (+0.83%)` | :arrow_up: |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `42.00% <0.00%> (-50.16%)` | :arrow_down: |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `53.84% <0.00%> (-46.16%)` | :arrow_down: |
| ... and [127 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...a7d9da5](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfe990d) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.36%`.
> The diff coverage is `89.55%`.
> :exclamation: Current head dfe990d differs from pull request most recent head 665c9c4. Consider uploading reports for the commit 665c9c4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.17% +0.36%
==========================================
Files 934 935 +1
Lines 47249 47407 +158
Branches 5892 5933 +41
==========================================
+ Hits 36294 36588 +294
+ Misses 10808 10675 -133
+ Partials 147 144 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.69% <88.46%> (+2.60%)` | :arrow_up: |
| hive | `80.29% <91.17%> (?)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `80.30% <91.17%> (?)` | |
| python | `80.77% <91.17%> (+0.21%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `46.99% <33.33%> (-21.65%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <50.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.21% <75.00%> (-2.42%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `93.10% <90.00%> (+2.62%)` | :arrow_up: |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `85.18% <100.00%> (-0.27%)` | :arrow_down: |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `89.47% <100.00%> (+0.58%)` | :arrow_up: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `92.85% <100.00%> (ø)` | |
| ... and [67 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...665c9c4](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.34%`.
> The diff coverage is `71.53%`.
> :exclamation: Current head 16db416 differs from pull request most recent head 5443ace. Consider uploading reports for the commit 5443ace to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.15% +0.34%
==========================================
Files 934 938 +4
Lines 47249 47568 +319
Branches 5892 6021 +129
==========================================
+ Hits 36294 36703 +409
+ Misses 10808 10718 -90
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <59.67%> (+2.93%)` | :arrow_up: |
| mysql | `80.60% <86.36%> (+0.02%)` | :arrow_up: |
| postgres | `80.63% <86.36%> (+0.15%)` | :arrow_up: |
| presto | `80.30% <86.36%> (?)` | |
| python | `80.88% <86.36%> (+0.32%)` | :arrow_up: |
| sqlite | `80.19% <86.36%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (ø)` | |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `69.64% <38.88%> (-19.25%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `82.92% <50.00%> (-9.94%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `71.08% <53.57%> (-14.38%)` | :arrow_down: |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...5443ace](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (16db416) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **increase** coverage by `0.23%`.
> The diff coverage is `71.53%`.
> :exclamation: Current head 16db416 differs from pull request most recent head 5443ace. Consider uploading reports for the commit 5443ace to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 76.81% 77.05% +0.23%
==========================================
Files 934 938 +4
Lines 47249 47568 +319
Branches 5892 6021 +129
==========================================
+ Hits 36294 36652 +358
+ Misses 10808 10769 -39
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <59.67%> (+2.93%)` | :arrow_up: |
| mysql | `80.60% <86.36%> (+0.02%)` | :arrow_up: |
| postgres | `80.64% <86.36%> (+0.15%)` | :arrow_up: |
| python | `80.68% <86.36%> (+0.11%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Loading/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `95.45% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <ø> (ø)` | |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <33.33%> (ø)` | |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | `69.64% <38.88%> (-19.25%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `82.92% <50.00%> (-9.94%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.07% <50.00%> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `71.08% <53.57%> (-14.38%)` | :arrow_down: |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...5443ace](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **increase** coverage by `0.18%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 79.21% 79.40% +0.18%
==========================================
Files 936 936
Lines 47408 47431 +23
Branches 5940 5938 -2
==========================================
+ Hits 37554 37661 +107
+ Misses 9727 9644 -83
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+0.01%)` | :arrow_up: |
| hive | `80.49% <93.93%> (+0.21%)` | :arrow_up: |
| mysql | `80.79% <93.93%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <93.93%> (+0.21%)` | :arrow_up: |
| presto | `80.51% <93.93%> (+0.21%)` | :arrow_up: |
| python | `81.36% <93.93%> (+0.21%)` | :arrow_up: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **increase** coverage by `0.10%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 79.21% 79.31% +0.10%
==========================================
Files 936 936
Lines 47408 47431 +23
Branches 5940 5938 -2
==========================================
+ Hits 37554 37622 +68
+ Misses 9727 9683 -44
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+0.01%)` | :arrow_up: |
| hive | `80.49% <93.93%> (+0.21%)` | :arrow_up: |
| mysql | `80.79% <93.93%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <93.93%> (+0.21%)` | :arrow_up: |
| presto | `?` | |
| python | `81.21% <93.93%> (+0.06%)` | :arrow_up: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (d70523a) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.22%`.
> The diff coverage is `91.03%`.
> :exclamation: Current head d70523a differs from pull request most recent head 1145f97. Consider uploading reports for the commit 1145f97 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 78.99% -0.23%
==========================================
Files 936 940 +4
Lines 47408 47571 +163
Branches 5940 5979 +39
==========================================
+ Hits 37554 37577 +23
- Misses 9727 9868 +141
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.76% <90.14%> (+0.15%)` | :arrow_up: |
| presto | `?` | |
| python | `80.76% <90.14%> (-0.40%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `41.02% <ø> (ø)` | |
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `50.00% <ø> (-30.96%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.86% <ø> (+0.74%)` | :arrow_up: |
| ... and [70 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...1145f97](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (f85bb82) into [master](https://codecov.io/gh/apache/superset/commit/d006178c03abd117ea1e61919d0d8a82099d0f1c?el=desc) (d006178) will **decrease** coverage by `0.43%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head f85bb82 differs from pull request most recent head a7d9da5. Consider uploading reports for the commit a7d9da5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 78.56% 78.13% -0.44%
==========================================
Files 935 935
Lines 47374 47376 +2
Branches 5971 5973 +2
==========================================
- Hits 37221 37016 -205
- Misses 10010 10213 +203
- Partials 143 147 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <80.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| python | `80.68% <80.00%> (-0.31%)` | :arrow_down: |
| sqlite | `80.16% <80.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `72.58% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.96% <100.00%> (+0.14%)` | :arrow_up: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (-28.13%)` | :arrow_down: |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | `70.17% <0.00%> (-19.30%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [d006178...a7d9da5](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #13827:
URL: https://github.com/apache/superset/pull/13827#discussion_r603165877
##########
File path: superset/reports/notifications/email.py
##########
@@ -70,9 +70,11 @@ def _get_content(self) -> EmailContent:
image = {msgid: self._content.screenshot.image}
body = __(
"""
+ <p>%(description)s</p>
Review comment:
Is the description just for emails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on a change in pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #13827:
URL: https://github.com/apache/superset/pull/13827#discussion_r607258534
##########
File path: superset/reports/notifications/email.py
##########
@@ -70,9 +70,11 @@ def _get_content(self) -> EmailContent:
image = {msgid: self._content.screenshot.image}
body = __(
"""
+ <p>%(description)s</p>
Review comment:
Yes, let's add description to slack notifs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (6004198) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.09%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head 6004198 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 79.11% -0.10%
==========================================
Files 936 936
Lines 47408 47409 +1
Branches 5940 5940
==========================================
- Hits 37554 37509 -45
- Misses 9727 9773 +46
Partials 127 127
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.28% <80.00%> (+<0.01%)` | :arrow_up: |
| mysql | `80.57% <80.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <80.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.96% <80.00%> (-0.19%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.42% <100.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.88% <0.00%> (-5.43%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.68%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (d70523a) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.19%`.
> The diff coverage is `91.03%`.
> :exclamation: Current head d70523a differs from pull request most recent head 1145f97. Consider uploading reports for the commit 1145f97 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 79.02% -0.20%
==========================================
Files 936 940 +4
Lines 47408 47598 +190
Branches 5940 5979 +39
==========================================
+ Hits 37554 37614 +60
- Misses 9727 9858 +131
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.77% <90.14%> (+0.16%)` | :arrow_up: |
| presto | `?` | |
| python | `80.81% <90.14%> (-0.34%)` | :arrow_down: |
| sqlite | `80.37% <90.14%> (+0.20%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `41.02% <ø> (ø)` | |
| [...dashboard/components/menu/ShareMenuItems/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvU2hhcmVNZW51SXRlbXMvaW5kZXgudHN4) | `25.00% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `50.00% <ø> (-30.96%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.86% <ø> (+0.74%)` | :arrow_up: |
| ... and [60 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...1145f97](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **decrease** coverage by `0.33%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 7ea1f64. Consider uploading reports for the commit 7ea1f64 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 79.21% 78.87% -0.34%
==========================================
Files 936 936
Lines 47408 47404 -4
Branches 5940 5938 -2
==========================================
- Hits 37554 37391 -163
- Misses 9727 9887 +160
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.38% <93.93%> (-0.77%)` | :arrow_down: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...7ea1f64](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett merged pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #13827:
URL: https://github.com/apache/superset/pull/13827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] samtfm commented on a change in pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
samtfm commented on a change in pull request #13827:
URL: https://github.com/apache/superset/pull/13827#discussion_r603663329
##########
File path: superset/reports/notifications/email.py
##########
@@ -70,9 +70,11 @@ def _get_content(self) -> EmailContent:
image = {msgid: self._content.screenshot.image}
body = __(
"""
+ <p>%(description)s</p>
Review comment:
that was the ask. Should I also add the description to slack notifications while I'm at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (dfa6be7) into [master](https://codecov.io/gh/apache/superset/commit/f06d53455c06a37b344dd33dea29070a1a3662d5?el=desc) (f06d534) will **increase** coverage by `0.18%`.
> The diff coverage is `91.48%`.
> :exclamation: Current head dfa6be7 differs from pull request most recent head 1145f97. Consider uploading reports for the commit 1145f97 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 79.21% 79.40% +0.18%
==========================================
Files 936 936
Lines 47408 47431 +23
Branches 5940 5938 -2
==========================================
+ Hits 37554 37661 +107
+ Misses 9727 9644 -83
+ Partials 127 126 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+0.01%)` | :arrow_up: |
| hive | `80.49% <93.93%> (+0.21%)` | :arrow_up: |
| mysql | `80.79% <93.93%> (+0.21%)` | :arrow_up: |
| postgres | `80.82% <93.93%> (+0.21%)` | :arrow_up: |
| presto | `80.51% <93.93%> (+0.21%)` | :arrow_up: |
| python | `81.36% <93.93%> (+0.21%)` | :arrow_up: |
| sqlite | `80.38% <93.93%> (+0.21%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.82% <75.00%> (-0.41%)` | :arrow_down: |
| [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==) | `71.55% <81.81%> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [f06d534...1145f97](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13827: feat: add descriptions to report emails
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13827:
URL: https://github.com/apache/superset/pull/13827#issuecomment-809833852
# [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=h1) Report
> Merging [#13827](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=desc) (e2d4562) into [master](https://codecov.io/gh/apache/superset/commit/db1d598f50f56f0aa8bf0a277b4c889a9b772ab6?el=desc) (db1d598) will **decrease** coverage by `0.26%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
- Coverage 76.81% 76.54% -0.27%
==========================================
Files 934 935 +1
Lines 47249 47241 -8
Branches 5892 5892
==========================================
- Hits 36294 36161 -133
- Misses 10808 10933 +125
Partials 147 147
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `?` | |
| python | `80.19% <80.00%> (-0.37%)` | :arrow_down: |
| sqlite | `80.19% <80.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <ø> (-0.05%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `84.78% <50.00%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.44% <100.00%> (ø)` | |
| [superset/reports/notifications/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL19faW5pdF9fLnB5) | `88.88% <100.00%> (ø)` | |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.45% <100.00%> (-0.20%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-20.69%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=footer). Last update [db1d598...e2d4562](https://codecov.io/gh/apache/superset/pull/13827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org