You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/09/13 10:51:30 UTC
[GitHub] [netbeans] eirikbakke commented on issue #1497: [NETBEANS-3072] Use
actual ImageIcons as code completion actually like.
eirikbakke commented on issue #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.
URL: https://github.com/apache/netbeans/pull/1497#issuecomment-531192084
The patch looks fine. As long as you use ImageUtilities.loadImageIcon, the resulting icon will actually still support HiDPI scaling. (It's a special subclass implementation of ImageIcon.)
The ClassCastException was due to assuming that ImageUtilities.image2icon returns an ImageIcon, which is no longer the case.
There's a lot of places in the NetBeans codebase that require an ImageIcon specifically, and the new ImageUtilities implementation allows these to remain mostly untouched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists