[GitHub] [thrift] tinloaf commented on a diff in pull request #2806: THRIFT-5709: Drastically improve to_string() performance.

["tinloaf (via GitHub)" <gi...@apache.org>]

tinloaf commented on code in PR #2806:
URL: https://github.com/apache/thrift/pull/2806#discussion_r1210080647


##########
lib/cpp/src/thrift/TToString.h:
##########
@@ -32,10 +32,15 @@
 namespace apache {
 namespace thrift {
 
+// unnamed namespace to enforce internal linkage - could be done with 'inline' when once have C++17

Review Comment:
   TODO: `when`/`once` is duplicate here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org