You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2025/01/22 12:31:24 UTC

[PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

nastra opened a new pull request, #12048:
URL: https://github.com/apache/iceberg/pull/12048

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on code in PR #12048:
URL: https://github.com/apache/iceberg/pull/12048#discussion_r1927198851


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -739,23 +749,31 @@ private Table createTablePartitioned(int partitions, int files, int numRecords)
   }
 
   private Table createTableUnpartitioned(int files, int numRecords) {
+    return createTableUnpartitioned(files, numRecords, 2);

Review Comment:
   I would probably just keep a 1 off table creator for V3 Tables rather than adding a new method which is parameterized solely for a single usage. 
   
   So we just inline 
   
   ```java
   
       Table table =
           validationCatalog.createTable(
               TableIdentifier.of("default", TABLE_NAME),
               SCHEMA,
               PartitionSpec.unpartitioned(),
               tableProperties());
               tableProperties(3));
   
       writeRecords(table, files, numRecords);
   ```
   
   In the V3 test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #12048:
URL: https://github.com/apache/iceberg/pull/12048#issuecomment-2611729505

   thanks for the reviews @RussellSpitzer @aokolnychyi. I'll go ahead and merge this for 1.8.0 since I don't have the PR ready  yet where we would support minor compactions for DVs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #12048:
URL: https://github.com/apache/iceberg/pull/12048#discussion_r1928166943


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -739,23 +749,31 @@ private Table createTablePartitioned(int partitions, int files, int numRecords)
   }
 
   private Table createTableUnpartitioned(int files, int numRecords) {
+    return createTableUnpartitioned(files, numRecords, 2);

Review Comment:
   makes sense to me, I've updated that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Spark: Disable rewriting position deletes for V3 tables [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #12048:
URL: https://github.com/apache/iceberg/pull/12048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org