You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/24 00:00:24 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12951: [Authorization Service] Remove unused authenticate method

michaeljmarshall opened a new pull request #12951:
URL: https://github.com/apache/pulsar/pull/12951


   Master Issue: https://github.com/apache/pulsar/issues/12105
   
   ### Motivation
   
   This is the start of my work implementing PIP 97. 
   
   When I removed the Discovery Service in https://github.com/apache/pulsar/pull/12119, I removed the last usage of the `AuthenticationService#authenticate` method. There is no need for this method, and instead of updating it to the async method (`provider.authenticate(authData)` was deprecated in PIP 97), it is better to remove it.
   
   ### Modifications
   
   * Remove `AuthenticationService#authenticate`
   * Remove the one test for the method
   
   ### Verifying this change
   
   This is a trivial change.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This is not a breaking change.
   
   ### Documentation
     
   - [x] `no-need-doc` 
     
   No docs need updating, as this is minor code cleanup.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #12951: [PIP 97][Authorization Service] Remove unused authenticate method

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12951:
URL: https://github.com/apache/pulsar/pull/12951


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org