You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/26 17:01:20 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #10387: Add CI to verify C++ client could be built on Windows

BewareMyPower opened a new pull request #10387:
URL: https://github.com/apache/pulsar/pull/10387


   ### Motivation
   
   I've seen many users have problems building Pulsar C++ client on Windows. Also there's no CI for Windows build now. After investigating on how to introduce 3rd party C++ libraries on Windows, I found [vcpkg](https://github.com/microsoft/vcpkg) is a simple solution, which supports downloading and building dependencies **from source** that could avoid ABI incompatibilies.
   
   ### Modifications
   
   - Add a `vcpkg.json` to specify the C++ client's dependencies. Here we can just import `boost` instead of `boost-[component name]`, however, it takes much more time on my laptop.
   - Remove some unused included headers to avoid useless dependency.
   - Add a workflow to build C++ client on Windows x64.
   - Update README to give a simple introduction on how to use `vcpkg` to build C++ client on Windows. On the other hand, some outdated descriptions are fixed.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10387: Add CI to verify C++ client could be built on Windows

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10387:
URL: https://github.com/apache/pulsar/pull/10387


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org