You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Chris Chabot (JIRA)" <ji...@apache.org> on 2008/07/02 20:49:44 UTC

[jira] Resolved: (SHINDIG-374) Proxy ignores e-tags / if-modified-since

     [ https://issues.apache.org/jira/browse/SHINDIG-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-374.
----------------------------------

    Resolution: Invalid
      Assignee: Chris Chabot

I've committed something of what i think is how it should work,. 

See http://svn.apache.org/viewvc?view=rev&revision=673461 for details.


> Proxy ignores e-tags / if-modified-since
> ----------------------------------------
>
>                 Key: SHINDIG-374
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-374
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: Chris Chabot
>            Assignee: Chris Chabot
>         Attachments: shindig-http-304-support.patch
>
>
> The ProxyHandler class does it's own header control instead of using the generic Servlet one because it requires full control over what headers are send.
> However this currently means it doesn't honor if-modified-since and e-tag headers, which causes the proxied files to always be re-downloaded by the web browser.
> On straight get's it should really:
> - If if-modified-since is set, and the cached file time is within the refreshInterval params value, return not-modified
> - Create it's own e-tag's (md5(responseBody)), and if the e-tag's match return a not-modified

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.