You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/11/08 09:01:42 UTC
[PR] [fix][test] Fix multiple thread leaks in tests, part 3 [pulsar]
lhotari opened a new pull request, #21543:
URL: https://github.com/apache/pulsar/pull/21543
### Motivation
There are thread leaks in tests reported by the thread leak detection added in #21450.
### Modifications
Fix multiple thread leaks in unit tests.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix multiple thread leaks in tests, part 3 [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21543:
URL: https://github.com/apache/pulsar/pull/21543#issuecomment-1801901074
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21543?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21543](https://app.codecov.io/gh/apache/pulsar/pull/21543?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7f48960) into [master](https://app.codecov.io/gh/apache/pulsar/commit/428c18c8d0c3d135189920740192982e11ffb2bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (428c18c) will **increase** coverage by `36.65%`.
> The diff coverage is `72.72%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21543 +/- ##
=============================================
+ Coverage 36.57% 73.23% +36.65%
- Complexity 12205 32673 +20468
=============================================
Files 1715 1892 +177
Lines 131092 140702 +9610
Branches 14300 15478 +1178
=============================================
+ Hits 47952 103047 +55095
+ Misses 76759 29545 -47214
- Partials 6381 8110 +1729
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21543/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.08% <0.00%> (-0.14%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.64% <0.00%> (-0.03%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.54% <72.72%> (+40.81%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/21543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...he/pulsar/client/impl/auth/AuthenticationSasl.java](https://app.codecov.io/gh/apache/pulsar/pull/21543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC1hdXRoLXNhc2wvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jbGllbnQvaW1wbC9hdXRoL0F1dGhlbnRpY2F0aW9uU2FzbC5qYXZh) | `69.50% <100.00%> (+69.50%)` | :arrow_up: |
| [...ker/authentication/AuthenticationProviderSasl.java](https://app.codecov.io/gh/apache/pulsar/pull/21543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1hdXRoLXNhc2wvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvYXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25Qcm92aWRlclNhc2wuamF2YQ==) | `59.23% <66.66%> (+59.23%)` | :arrow_up: |
| [...rg/apache/pulsar/common/sasl/TGTRefreshThread.java](https://app.codecov.io/gh/apache/pulsar/pull/21543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9zYXNsL1RHVFJlZnJlc2hUaHJlYWQuamF2YQ==) | `25.92% <0.00%> (+25.92%)` | :arrow_up: |
| [...esystem/impl/FileSystemManagedLedgerOffloader.java](https://app.codecov.io/gh/apache/pulsar/pull/21543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkLXN0b3JhZ2UvZmlsZS1zeXN0ZW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9vZmZsb2FkL2ZpbGVzeXN0ZW0vaW1wbC9GaWxlU3lzdGVtTWFuYWdlZExlZGdlck9mZmxvYWRlci5qYXZh) | `69.38% <50.00%> (ø)` | |
... and [1456 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21543/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix multiple thread leaks in tests, part 3 [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #21543:
URL: https://github.com/apache/pulsar/pull/21543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org