You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "sunheyi6 (via GitHub)" <gi...@apache.org> on 2023/10/25 08:25:22 UTC
[PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
sunheyi6 opened a new pull request, #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "sunheyi6 (via GitHub)" <gi...@apache.org>.
sunheyi6 commented on PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#issuecomment-1793928815
@Xuanwo cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "G-XD (via GitHub)" <gi...@apache.org>.
G-XD commented on code in PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#discussion_r1396836613
##########
.github/services/redis/redis_with_cluster_tls/action.yml:
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: redis_with_cluster_tls
+description: 'Behavior test for redis with cluster tls'
+
+runs:
+ using: "composite"
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Redis Cluster with TLS
+ shell: bash
+ working-directory: fixtures/redis
+ run: |
+
+ # Install the CA in the system
+
+ sudo cp ssl/ca.crt /usr/local/share/ca-certificates
+ sudo update-ca-certificates
+
+ docker compose -f docker-compose-redis-cluster-tls.yml up -d --wait
+
+ - name: Setup
+ shell: bash
+ run: |
+ cat << EOF >> $GITHUB_ENV
+ OPENDAL_REDIS_CLUSTER_ENDPOINTS=rediss://127.0.0.1:6380/,rediss://127.0.0.1:6381/,rediss://127.0.0.1:6382/,rediss://127.0.0.1:6383/,rediss://127.0.0.1:6384/,rediss://127.0.0.1:6385/
+ OPENDAL_REDIS_ROOT=/test/opendal
Review Comment:
you need add `OPENDAL_REDIS_PASSWORD=opendal`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#discussion_r1384863717
##########
.github/services/redis/redis_with_cluster_tls/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: redis_with_cluster_tls
+description: 'Behavior test for redis with cluster tls'
+
+runs:
+ using: "composite"
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Redis Cluster with TLS
+ shell: bash
+ working-directory: fixtures/redis
+ run: |
+
+ # Install the CA in the system
+
+ sudo cp ssl/ca.crt /usr/local/share/ca-certificates
+ sudo update-ca-certificates
+
+ docker-compose -f docker-compose-redis-cluster-tls.yml up -d
+
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ with:
+ need-nextest: true
+
+ - name: Test
+ shell: bash
+ run: |
+ cat << EOF >> $GITHUB_ENV
+ OPENDAL_REDIS_CLUSTER_ENDPOINTS=redis://127.0.0.1:6380/,redis://127.0.0.1:6381/,redis://127.0.0.1:6382/,redis://127.0.0.1:6383/,redis://127.0.0.1:6384/,redis://127.0.0.1:6385/
Review Comment:
should be `rediss://127.0.0.1:6380/,rediss://127.0.0.1:6381/,rediss://127.0.0.1:6382/,rediss://127.0.0.1:6383/,rediss://127.0.0.1:6384/,rediss://127.0.0.1:6385/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#issuecomment-1791901455
https://github.com/apache/incubator-opendal/pull/3471 has been merged, you can continue your work now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "G-XD (via GitHub)" <gi...@apache.org>.
G-XD commented on code in PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#discussion_r1396670535
##########
.github/services/redis/redis_tls/action.yml:
##########
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: redis_tls
+description: 'Behavior test for redis tls'
+
+runs:
+ using: "composite"
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Redis with TLS
+ shell: bash
+ working-directory: fixtures/redis
+ run: |
+ # Install the CA in the system
+ sudo cp ssl/ca.crt /usr/local/share/ca-certificates
+ sudo update-ca-certificates
+
+ docker compose -f docker-compose-redis-tls.yml up -d --wait
+ - name: Setup
+ shell: bash
+ run: |
+ cat << EOF >> $GITHUB_ENV
+ OPENDAL_REDIS_ENDPOINT=tcp://127.0.0.1:6379
Review Comment:
should be `rediss://127.0.0.1:6379`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "sunheyi6 (via GitHub)" <gi...@apache.org>.
sunheyi6 commented on PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#issuecomment-1815931960
@Xuanwo cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "sunheyi6 (via GitHub)" <gi...@apache.org>.
sunheyi6 commented on code in PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#discussion_r1396852426
##########
.github/services/redis/redis_with_cluster_tls/action.yml:
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: redis_with_cluster_tls
+description: 'Behavior test for redis with cluster tls'
+
+runs:
+ using: "composite"
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Setup Redis Cluster with TLS
+ shell: bash
+ working-directory: fixtures/redis
+ run: |
+
+ # Install the CA in the system
+
+ sudo cp ssl/ca.crt /usr/local/share/ca-certificates
+ sudo update-ca-certificates
+
+ docker compose -f docker-compose-redis-cluster-tls.yml up -d --wait
+
+ - name: Setup
+ shell: bash
+ run: |
+ cat << EOF >> $GITHUB_ENV
+ OPENDAL_REDIS_CLUSTER_ENDPOINTS=rediss://127.0.0.1:6380/,rediss://127.0.0.1:6381/,rediss://127.0.0.1:6382/,rediss://127.0.0.1:6383/,rediss://127.0.0.1:6384/,rediss://127.0.0.1:6385/
+ OPENDAL_REDIS_ROOT=/test/opendal
Review Comment:
thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "sunheyi6 (via GitHub)" <gi...@apache.org>.
sunheyi6 commented on PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#issuecomment-1815926099
@PsiACE cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(service/redis): Migrate task to new task planner [incubator-opendal]
Posted by "sunheyi6 (via GitHub)" <gi...@apache.org>.
sunheyi6 commented on PR #3374:
URL: https://github.com/apache/incubator-opendal/pull/3374#issuecomment-1815830539
@G-XD Can you help me check why my redis-with-cluster-cls did not pass the CI test? I have tried quite a bit, but it seems that I can't solve this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org