[jira] [Comment Edited] (SLING-8946) Non-deterministic shadowing of resource observation

["Sonal Gupta (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029740#comment-17029740 ] 

Sonal Gupta edited comment on SLING-8946 at 2/4/20 10:38 AM:
-------------------------------------------------------------

[~diru] Some tests are still failing. Can you please look into the same. Use the attached test2.zip and command 

mvn clean verify -Dgranite.it.author.url=http://<server>:<port> -Dgranite.it.publish.url=http://<server>:<port> -Dtest=com/adobe/cq/xf/it/adobetarget/TargetIntegrationIT.java

 

List of failing tests : 
 * [com.adobe.cq.xf.it.adobetarget.TargetIntegrationIT.testUpdatePageStatus|https://noida-evergreen.ci.corp.adobe.com:12001/job/Evergreen-IT-6.4.0/1545/featureGroup=commerce,label=evergreen/testReport/junit/com.adobe.cq.xf.it.adobetarget/TargetIntegrationIT/testUpdatePageStatus/]
 * [com.adobe.cq.xf.it.adobetarget.TargetIntegrationIT.testExportToTarget|https://noida-evergreen.ci.corp.adobe.com:12001/job/Evergreen-IT-6.4.0/1545/featureGroup=commerce,label=evergreen/testReport/junit/com.adobe.cq.xf.it.adobetarget/TargetIntegrationIT/testExportToTarget/]
 * [com.adobe.cq.xf.it.adobetarget.TargetIntegrationIT.testDeleteInTarget|https://noida-evergreen.ci.corp.adobe.com:12001/job/Evergreen-IT-6.4.0/1545/featureGroup=commerce,label=evergreen/testReport/junit/com.adobe.cq.xf.it.adobetarget/TargetIntegrationIT/testDeleteInTarget/]
 * [com.adobe.cq.xf.it.socialmedia_integration.facebook.FacebookIT.endToEnd|https://noida-evergreen.ci.corp.adobe.com:12001/job/Evergreen-IT-6.4.0/1545/featureGroup=commerce,label=evergreen/testReport/junit/com.adobe.cq.xf.it.socialmedia_integration.facebook/FacebookIT/endToEnd/]
 * [com.adobe.cq.xf.it.socialmedia_integration.pinterest.PinterestIT.endToEnd|https://noida-evergreen.ci.corp.adobe.com:12001/job/Evergreen-IT-6.4.0/1545/featureGroup=commerce,label=evergreen/testReport/junit/com.adobe.cq.xf.it.socialmedia_integration.pinterest/PinterestIT/endToEnd/]


was (Author: sonagupt):
[~diru] Some tests are still failing. Can you please look into the same. Use the attached test2.zip and command 

mvn clean verify -Dgranite.it.author.url=http://<server>:<port> -Dgranite.it.publish.url=http://<server>:<port> -Dtest=com/adobe/cq/xf/it/adobetarget/TargetIntegrationIT.java

> Non-deterministic shadowing of resource observation
> ---------------------------------------------------
>
>                 Key: SLING-8946
>                 URL: https://issues.apache.org/jira/browse/SLING-8946
>             Project: Sling
>          Issue Type: Bug
>          Components: ResourceResolver
>    Affects Versions: Resource Resolver 1.5.34
>            Reporter: Dirk Rudolph
>            Assignee: Robert Munteanu
>            Priority: Critical
>             Fix For: Resource Resolver 1.6.18
>
>         Attachments: test.zip, test2.zip
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The BasicObservationReporter implements shadowing of events being propagated per ResourceProvider instance [1]. Assuming we do have 2 ResourceProviders registered, where the one shadows the other like this:
>  - RP A registered on /
>  - RP B registered on /path
> then currently the excludes given to the BasicObservationReporter are different depending on either RP A or RP B gets registered first:
>  - RP A before RP B => excludes are empty
>  - RP B before RP A => excludes contain /path
> This is because only the newly registered RP gets its ProviderContext updated [2]
> Same applies if RP B is registered before RP A and gets unregistered. In that case the ObservationReporter of RP A stays untouched.
> [1] [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L102]
>  [2] [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTracker.java#L358]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)