[GitHub] [hive] abstractdog commented on a change in pull request #2513: HIVE-25362: LLAP: ensure tasks with locality have a chance to adjust delay

[GitBox <gi...@apache.org>]

abstractdog commented on a change in pull request #2513:
URL: https://github.com/apache/hive/pull/2513#discussion_r674637137



##########
File path: llap-tez/src/test/org/apache/hadoop/hive/llap/tezplugins/TestLlapTaskSchedulerService.java
##########
@@ -904,6 +904,48 @@ private void forceLocalityTest1(boolean forceLocality) throws IOException, Inter
     }
   }
 
+  @Test(timeout = 10000)

Review comment:
       this unit test passes also without the patch, could you please include some assertion proving this fix? I believe it should assert that in case of no available hosts request.resetLocalityDelayInfo() is not called




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org