You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2015/07/09 22:32:57 UTC
incubator-reef git commit: [REEF-466] Remove the public key on
`InternalsVisibleTo` in DEBUG builds
Repository: incubator-reef
Updated Branches:
refs/heads/master 87c181dc8 -> 4853a2857
[REEF-466] Remove the public key on `InternalsVisibleTo` in DEBUG builds
There is an error in debug build as friend access was granted with
public key but the module is not signed. This change makes it so that
we only require the key for RELEASE builds.
JIRA:
[REEF-466](https://issues.apache.org/jira/browse/REEF-466)
Pull Request:
This closes #286
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/4853a285
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/4853a285
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/4853a285
Branch: refs/heads/master
Commit: 4853a285780b0d93ea654c2ca86c01b4ca3b878e
Parents: 87c181d
Author: Julia Wang <jw...@yahoo.com>
Authored: Wed Jul 8 14:57:22 2015 -0700
Committer: Markus Weimer <we...@apache.org>
Committed: Thu Jul 9 13:29:18 2015 -0700
----------------------------------------------------------------------
lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs | 7 ++++++-
lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs | 6 +++++-
lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs | 6 +++++-
lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs | 6 +++++-
lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs | 6 +++++-
5 files changed, 26 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/4853a285/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs
index 46ff36e..bc43da4 100644
--- a/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs
+++ b/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs
@@ -55,8 +55,13 @@ using System.Runtime.InteropServices;
[assembly: AssemblyFileVersion("0.12.0.0")]
// Allow the tests access to `internal` APIs
+
+#if DEBUG
+[assembly: InternalsVisibleTo("Org.Apache.REEF.Common.Tests")]
+#else
[assembly: InternalsVisibleTo("Org.Apache.REEF.Common.Tests, publickey=" +
"00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" +
"9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" +
"b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" +
- "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
\ No newline at end of file
+ "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
+#endif
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/4853a285/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs
index 2735ea9..cd6c831 100644
--- a/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs
+++ b/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs
@@ -33,8 +33,12 @@ using System.Runtime.InteropServices;
[assembly: AssemblyVersion("0.12.0.0")]
[assembly: AssemblyFileVersion("0.12.0.0")]
// Allow the tests project access to `internal` APIs
+#if DEBUG
+[assembly: InternalsVisibleTo("Org.Apache.REEF.IMRU.Tests")]
+#else
[assembly: InternalsVisibleTo("Org.Apache.REEF.IMRU.Tests, publickey=" +
"00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" +
"9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" +
"b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" +
- "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
\ No newline at end of file
+ "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
+#endif
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/4853a285/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs
index e1cf5f3..7b0064c 100644
--- a/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs
+++ b/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs
@@ -55,8 +55,12 @@ using System.Runtime.InteropServices;
[assembly: AssemblyFileVersion("0.12.0.0")]
// Allow the tests access to `internal` APIs
+#if DEBUG
+[assembly: InternalsVisibleTo("Org.Apache.REEF.Network.Tests")]
+#else
[assembly: InternalsVisibleTo("Org.Apache.REEF.Network.Tests, publickey=" +
"00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" +
"9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" +
"b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" +
- "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
\ No newline at end of file
+ "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
+#endif
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/4853a285/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs
index 7d1fbe9..dfbbe77 100644
--- a/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs
+++ b/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs
@@ -55,8 +55,12 @@ using System.Runtime.InteropServices;
[assembly: AssemblyFileVersion("0.12.0.0")]
// Allow the tests access to `internal` APIs
+#if DEBUG
+[assembly: InternalsVisibleTo("Org.Apache.REEF.Tang.Tests")]
+#else
[assembly: InternalsVisibleTo("Org.Apache.REEF.Tang.Tests, publickey=" +
"00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" +
"9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" +
"b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" +
- "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
\ No newline at end of file
+ "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
+#endif
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/4853a285/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs
index 3750adf..bea835a 100644
--- a/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs
+++ b/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs
@@ -55,8 +55,12 @@ using System.Runtime.InteropServices;
[assembly: AssemblyFileVersion("0.12.0.0")]
// Allow the tests access to `internal` APIs
+#if DEBUG
+[assembly: InternalsVisibleTo("Org.Apache.REEF.Wake.Tests")]
+#else
[assembly: InternalsVisibleTo("Org.Apache.REEF.Wake.Tests, publickey=" +
"00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" +
"9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" +
"b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" +
- "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
\ No newline at end of file
+ "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")]
+#endif
\ No newline at end of file