[jira] [Commented] (OAK-931) Importer: review usage of write-root and objects obtained from the sessioncontext

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819128#comment-13819128 ] 

angela commented on OAK-931:
----------------------------

[~chetanm] i am really not happy with the introduction and the naming of 'initialRoot' vs 'root' which are both passed to the Importer. this looks very troublesome to me and not maintainable.

please, refactor the code such that only one root is passed to the Importer.



> Importer: review usage of write-root and objects obtained from the sessioncontext
> ---------------------------------------------------------------------------------
>
>                 Key: OAK-931
>                 URL: https://issues.apache.org/jira/browse/OAK-931
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: jcr
>            Reporter: angela
>             Fix For: 0.11
>
>
> the current importer code (both for session and workspace import) is mixing objects based on the write-root and those based on the editing session context (which in case of a workspace import is associated with a different Root).
> while up to now i didn't see any failing test, i still suspect that this could lead to issues during the import in particular when it comes to node type validation.
> therefore opening this issue as a reminder and as issue reference for a TODO in the code.



--
This message was sent by Atlassian JIRA
(v6.1#6144)