[GitHub] [drill] cgivre commented on a change in pull request #2264: Drill 7955: Extend XOR bitwise functions to match AND and OR

[GitBox <gi...@apache.org>]

cgivre commented on a change in pull request #2264:
URL: https://github.com/apache/drill/pull/2264#discussion_r657984415



##########
File path: exec/java-exec/src/main/codegen/data/MathFunc.tdd
##########
@@ -138,7 +138,7 @@ unaryMathFunctions : [
       {input: "UInt8", outputType: "UInt8", castType: "long"}
      ] 
     },
-    {className: "LeftShift", funcName: "lshift", javaFunc: " << ", types: [
+    {className: "LeftShift", funcName: "lshift", aliasName: "", javaFunc: " << ", types: [

Review comment:
       Would we want this for all `INT` types like `SHORT`, `TINYINT` etc?

##########
File path: exec/java-exec/src/main/codegen/data/MathFunc.tdd
##########
@@ -125,7 +125,7 @@ unaryMathFunctions : [
       {input: "UInt8", outputType: "UInt8", castType: "long"}     
      ] 
     },
-    {className: "Mod", funcName: "mod", javaFunc : " % ", types: [
+    {className: "Mod", funcName: "mod", aliasName: "", javaFunc : " % ", types: [

Review comment:
       Same comment as elsewhere... would we want this for other `INT` like data types or does Drill handle that elsewhere?

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BitFunctions.java
##########
@@ -71,22 +70,4 @@ public void eval() {
     }
   }
 

Review comment:
       Out of curiosity, why is this being deleted?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org