You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2019/02/02 11:50:53 UTC
[GitHub] [geode] jinmeiliao opened pull request #3156: GEODE-6322:
refactor createRegionCommand to use RegionConfig only
* get rid of usages of xxxArgs and RegionConfigFactory
* the resulting cluster configuration xml for region does not have excessive default values
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #3156: GEODE-6322:
refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
@onichols-pivotal @Petahhh
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pdxrunner commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "pdxrunner (GitHub)" <gi...@apache.org>.
The semantics of this is kind of ugly (i.e. non-intuitive). We're testing that a method that returns a Boolean to return null. Yes, I realize the declared return type (`Boolean`) could be null, but that confuses the intent of a method named `isXxxxx()`
The logic in `public boolean isConcurrencyChecksEnabled()` is more intuitive.
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
I think this would be better as a method on `RegionConfig` - maybe `mergeEntryIdleTime`. I realize that it would actually result in 4 methods: `merge[Entry|Region][IdleTime|TimeToLive]`. That way it would also be more 'discoverable' by someone scanning the API for `RegionConfig`.
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
fixed in latest commit.
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
these code are auto generated by jaxb. I believe `public boolean isConcurrencyChecksEnabled()` returns a `boolean` is because that attribute has a default defined in the xsd, which others don't.
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pdxrunner commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "pdxrunner (GitHub)" <gi...@apache.org>.
This does not need to be a spy, just instantiate a `new RegionConfigRealzer()`
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pdxrunner commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "pdxrunner (GitHub)" <gi...@apache.org>.
another minor comment re-wording:
```
// ... execute a function on the member ...
```
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pdxrunner commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "pdxrunner (GitHub)" <gi...@apache.org>.
Minor nit-pick: comment would read better as
```
// ... go to the member...
```
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
agree
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
fixed in latest commit
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
A corner case here is if we have a mix of **accessor** and **hosting** members - the template would look different on different members. In this case, I suggest we fail and not allow that.
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
good find. Will add in checks.
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
fixed in latest commit
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
good idea. I thought about this as well, but just didn't want to add four methods. The argument of "discoverability" convinced me.
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao closed pull request #3156: GEODE-6322:
refactor createRegionCommand to use RegionConfig only
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3156:
GEODE-6322: refactor createRegionCommand to use RegionConfig only
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
Ditto above
[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org