[GitHub] [arrow] jhorstmann commented on a change in pull request #9211: ARROW-11239: [Rust] Fixed equality with offsets and nulls

[GitBox <gi...@apache.org>]

jhorstmann commented on a change in pull request #9211:
URL: https://github.com/apache/arrow/pull/9211#discussion_r559392711



##########
File path: rust/arrow/src/array/equal/list.rs
##########
@@ -151,8 +151,8 @@ pub(super) fn list_equal<T: OffsetSizeTrait>(
             let lhs_pos = lhs_start + i;
             let rhs_pos = rhs_start + i;
 
-            let lhs_is_null = !get_bit(lhs_null_bytes, lhs_pos);
-            let rhs_is_null = !get_bit(rhs_null_bytes, rhs_pos);
+            let lhs_is_null = !get_bit(lhs_null_bytes, lhs_pos + lhs.offset());

Review comment:
       There is another lhs/rhs mixup a few lines above (148), github won't let me comment on that line:
   ```
           // get a ref of the parent null buffer bytes, to use in testing for nullness
           let lhs_null_bytes = rhs_nulls.unwrap().as_slice();
                                ^
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org