You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/14 07:45:27 UTC

[kudu-CR] java: don't preallocate log segments in java tests 

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5499

to review the following change.

Change subject: java: don't preallocate log segments in java tests
......................................................................

java: don't preallocate log segments in java tests

This disables log segment preallocation for the Java tests. With log
preallocation on, the test data directory needed more than 10GB free to
pass. Now, it peaks at ~10MB of space required, with no loss in
coverage.

Change-Id: Icf1d5bdec2cf653abab5f836a3c99c2f1d9944e5
---
M java/kudu-client/src/test/resources/flags
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/5499/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf1d5bdec2cf653abab5f836a3c99c2f1d9944e5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>

[kudu-CR] java: don't preallocate log segments in java tests

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: java: don't preallocate log segments in java tests
......................................................................


java: don't preallocate log segments in java tests

This disables log segment preallocation for the Java tests. With log
preallocation on, the test data directory needed more than 10GB free to
pass. Now, it peaks at ~10MB of space required, with no loss in
coverage.

Change-Id: Icf1d5bdec2cf653abab5f836a3c99c2f1d9944e5
Reviewed-on: http://gerrit.cloudera.org:8080/5499
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/src/test/resources/flags
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf1d5bdec2cf653abab5f836a3c99c2f1d9944e5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] java: don't preallocate log segments in java tests

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: java: don't preallocate log segments in java tests
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d5bdec2cf653abab5f836a3c99c2f1d9944e5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No