You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/06 06:12:22 UTC
[GitHub] [arrow] emkornfield commented on a change in pull request #12296: ARROW-15502: [Java] Detect exceptional footer size in Arrow file reader
emkornfield commented on a change in pull request #12296:
URL: https://github.com/apache/arrow/pull/12296#discussion_r800131518
##########
File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowMagic.java
##########
@@ -27,9 +27,9 @@
class ArrowMagic {
private ArrowMagic(){}
- private static final byte[] MAGIC = "ARROW1".getBytes(StandardCharsets.UTF_8);
+ static final byte[] MAGIC = "ARROW1".getBytes(StandardCharsets.UTF_8);
- public static final int MAGIC_LENGTH = MAGIC.length;
+ static final int MAGIC_LENGTH = MAGIC.length;
Review comment:
why make this package private? This seems like an unnecessary API breakage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org