You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by caspersmith <gi...@git.apache.org> on 2014/08/20 06:57:06 UTC
[GitHub] cordova-android pull request: custom_rules.xml breaks library refe...
GitHub user caspersmith opened a pull request:
https://github.com/apache/cordova-android/pull/114
custom_rules.xml breaks library references
If the cordova project lives under another another directory called 'bin' then it will also be replaced with 'ant-build' which results in build failure. This fix ensures that only the instance of 'CordovaLib/bin' is changed to 'CordovaLib/ant-build'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caspersmith/cordova-android patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit c9792aa0431aaf297e3ce05ff5620fa9a9740aa4
Author: caspersmith <ca...@gmail.com>
Date: 2014-08-20T04:56:40Z
custom_rules.xml breaks library references
If the cordova project lives under another another directory called 'bin' then it will also be replaced with 'ant-build' which results in build failure. This fix ensures that only the instance of 'CordovaLib/bin' is changed to 'CordovaLib/ant-build'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: custom_rules.xml breaks library refe...
Posted by caspersmith <gi...@git.apache.org>.
Github user caspersmith commented on the pull request:
https://github.com/apache/cordova-android/pull/114#issuecomment-52858077
We want to generate the cordova project inside the 'bin/' output directory of our project. The directory structure is '/Users/casper/our-project/bin/debug/cordova/'.
The issue is, during the build process this build rule will replace all instances of bin with apache-ant in the entire path when setting the jars path. As a result the path at '/Users/casper/our-project/bin' becomes '/Users/casper/our-project/apache-ant'
During compile we can see this happening:
<pre>
-pre-compile:
[echo] Set jars path to: /Users/casper/our-project/<b>ant-build</b>/debug/cordova/platforms/android/CordovaLib/<b>ant-build</b>/classes.jar
</pre>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: custom_rules.xml breaks library refe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: custom_rules.xml breaks library refe...
Posted by caspersmith <gi...@git.apache.org>.
GitHub user caspersmith reopened a pull request:
https://github.com/apache/cordova-android/pull/114
custom_rules.xml breaks library references
If the cordova project lives under another another directory called 'bin' then it will also be replaced with 'ant-build' which results in build failure. This fix ensures that only the instance of 'CordovaLib/bin' is changed to 'CordovaLib/ant-build'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caspersmith/cordova-android patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit c9792aa0431aaf297e3ce05ff5620fa9a9740aa4
Author: caspersmith <ca...@gmail.com>
Date: 2014-08-20T04:56:40Z
custom_rules.xml breaks library references
If the cordova project lives under another another directory called 'bin' then it will also be replaced with 'ant-build' which results in build failure. This fix ensures that only the instance of 'CordovaLib/bin' is changed to 'CordovaLib/ant-build'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: custom_rules.xml breaks library refe...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/114#issuecomment-54914245
aha, that makes sense.
Unfortunately, the renaming needs to happen for all sub-projects (plugins can include subprojects as well), not just for CordovaLib.
Are you able to figure out how to get ant to just replace the last occurrence of "bin" within the path?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: custom_rules.xml breaks library refe...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/114#issuecomment-52784679
Thanks for this. The original intention of changing to ant-build is to prevent a conflict with Eclipse's build. So, it was meant to apply to all sub-projects, not just CordovaLib.
That said, we've seen that it does break when sub-projects have resources. Is that what you're experiencing? Would be good to write a bug report saying exactly what breaks to justify this change (I can create the report if you just reply here, or if you want, you can do it at https://issues.apache.org/jira/browse/CB).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: custom_rules.xml breaks library refe...
Posted by caspersmith <gi...@git.apache.org>.
Github user caspersmith closed the pull request at:
https://github.com/apache/cordova-android/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---