You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by vi...@apache.org on 2018/06/22 19:10:59 UTC
hive git commit: HIVE-19942 : Hive Notification: All events for
indexes should have table name (Bharathkrishna Guruvayoor Murali,
reviewed by Vihang Karajgaonkar)
Repository: hive
Updated Branches:
refs/heads/branch-2 342757bed -> 498021fa1
HIVE-19942 : Hive Notification: All events for indexes should have table name (Bharathkrishna Guruvayoor Murali, reviewed by Vihang Karajgaonkar)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/498021fa
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/498021fa
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/498021fa
Branch: refs/heads/branch-2
Commit: 498021fa15186aee8b282d3c032fbd2cede6bec4
Parents: 342757b
Author: Bharathkrishna Guruvayoor Murali <bh...@cloudera.com>
Authored: Fri Jun 22 12:02:19 2018 -0700
Committer: Vihang Karajgaonkar <vi...@cloudera.com>
Committed: Fri Jun 22 12:02:19 2018 -0700
----------------------------------------------------------------------
.../org/apache/hive/hcatalog/listener/DbNotificationListener.java | 3 +++
.../apache/hive/hcatalog/listener/TestDbNotificationListener.java | 3 +++
2 files changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/498021fa/hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
----------------------------------------------------------------------
diff --git a/hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java b/hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
index 8114d35..5fbba0a 100644
--- a/hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
+++ b/hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
@@ -411,6 +411,7 @@ public class DbNotificationListener extends MetaStoreEventListener {
new NotificationEvent(0, now(), EventType.CREATE_INDEX.toString(), msgFactory
.buildCreateIndexMessage(index).toString());
event.setDbName(index.getDbName());
+ event.setTableName(index.getOrigTableName());
process(event, indexEvent);
}
@@ -425,6 +426,7 @@ public class DbNotificationListener extends MetaStoreEventListener {
new NotificationEvent(0, now(), EventType.DROP_INDEX.toString(), msgFactory
.buildDropIndexMessage(index).toString());
event.setDbName(index.getDbName());
+ event.setTableName(index.getOrigTableName());
process(event, indexEvent);
}
@@ -440,6 +442,7 @@ public class DbNotificationListener extends MetaStoreEventListener {
new NotificationEvent(0, now(), EventType.ALTER_INDEX.toString(), msgFactory
.buildAlterIndexMessage(before, after).toString());
event.setDbName(before.getDbName());
+ event.setTableName(before.getOrigTableName());
process(event, indexEvent);
}
http://git-wip-us.apache.org/repos/asf/hive/blob/498021fa/itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
----------------------------------------------------------------------
diff --git a/itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java b/itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
index 2697509..93acf2b 100644
--- a/itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
+++ b/itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
@@ -1029,6 +1029,7 @@ public class TestDbNotificationListener {
assertTrue(event.getEventTime() >= startTime);
assertEquals(EventType.CREATE_INDEX.toString(), event.getEventType());
assertEquals(dbName, event.getDbName());
+ assertEquals(tableName.toLowerCase(), event.getTableName().toLowerCase());
// Parse the message field
CreateIndexMessage createIdxMessage = md.getCreateIndexMessage(event.getMessage());
@@ -1102,6 +1103,7 @@ public class TestDbNotificationListener {
assertTrue(event.getEventTime() >= startTime);
assertEquals(EventType.DROP_INDEX.toString(), event.getEventType());
assertEquals(dbName, event.getDbName());
+ assertEquals(tableName.toLowerCase(), event.getTableName().toLowerCase());
// Parse the message field
DropIndexMessage dropIdxMsg = md.getDropIndexMessage(event.getMessage());
@@ -1180,6 +1182,7 @@ public class TestDbNotificationListener {
assertTrue(event.getEventTime() >= startTime);
assertEquals(EventType.ALTER_INDEX.toString(), event.getEventType());
assertEquals(dbName, event.getDbName());
+ assertEquals(tableName.toLowerCase(), event.getTableName().toLowerCase());
// Parse the message field
AlterIndexMessage alterIdxMsg = md.getAlterIndexMessage(event.getMessage());