You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/12 06:53:54 UTC

[GitHub] [flink] swuferhong opened a new pull request, #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

swuferhong opened a new pull request, #21490:
URL: https://github.com/apache/flink/pull/21490

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   This pr is aims to fix calcite method `RelMdUtil$numDistinctVals()` wrongly return zero if the method input `domainSize` is a very large value.  If `domainSize` is a very large value (like 2 x 10^16), Math.log(1.0 - 1.0 / dSize) will return 0, and `domainSize` will be set to 0, which is unreasonable in this scenario. (This bug will let join type choose `NestedLoopJoin` instead of `HashJoin` in physical program).
   
   ## Brief change log
   - Class `RelMdUtil` is copied from calcite `org.apache.calcite.rel.metadata.RelMdUtil`, and modified method `numDistinctVals()`.
   
   
   ## Verifying this change
   
   No tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
     - If yes, how is the feature documented?  no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] swuferhong commented on pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
swuferhong commented on PR #21490:
URL: https://github.com/apache/flink/pull/21490#issuecomment-1347612522

   > Thanks for your contribution Could you please clarify how we can be sure that this change does what expected? May be some tests could be helpful to have.
   > 
   > Also it would be helpful to have info about what lines are changed in this class, like it is done e.g. in `RexSimplify`, `SqlToRelConverter` and other Calcite's classes
   > 
   > And another question: shouldn't this issue be raised in Calcite's jira?
   
   Hi, This bug was found in the `tpc-ds` benchmark tests. So it was difficult to reproduce in Flink ut test case, but I will try to reproduce it .
   
   OK, I will add more information in class annotation.
   
   I think it necessary to open a jira in calcite, and I will do it, Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] swuferhong commented on a diff in pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
swuferhong commented on code in PR #21490:
URL: https://github.com/apache/flink/pull/21490#discussion_r1057401207


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelMdUtil.scala:
##########
@@ -247,6 +248,77 @@ object FlinkRelMdUtil {
     RexUtil.composeConjunction(rexBuilder, pushable, true)
   }
 
+  /**
+   * This method is copied from calcite RelMdUtil. This method should be removed once CALCITE-4351
+   * is fixed. See CALCITE-4351 and FLINK-19780.
+   *
+   * Computes the number of distinct rows for a set of keys returned from a join. Also known as NDV
+   * (number of distinct values).
+   *
+   * @param joinRel
+   *   RelNode representing the join
+   * @param joinType
+   *   type of join
+   * @param groupKey
+   *   keys that the distinct row count will be computed for
+   * @param predicate
+   *   join predicate
+   * @param useMaxNdv
+   *   If true use formula <code>max(left NDV, right NDV)</code>, otherwise use <code>left NDV *
+   *   right NDV</code>.
+   * @return
+   *   number of distinct rows
+   */
+  def getJoinDistinctRowCount(
+      mq: RelMetadataQuery,
+      joinRel: RelNode,
+      joinType: JoinRelType,
+      groupKey: ImmutableBitSet,
+      predicate: RexNode,
+      useMaxNdv: Boolean): Double = {
+    if ((predicate == null || predicate.isAlwaysTrue) && groupKey.isEmpty) return 1d

Review Comment:
   > please format the copied code
   
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin commented on pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #21490:
URL: https://github.com/apache/flink/pull/21490#issuecomment-1346155848

   Thanks for your contribution
   Could you please clarify how we can be sure that this change does what expected?
   May be some tests could be helpful to have.
   
   Also it would be helpful to have info about what lines are changed in this class, like it is done e.g. in `RexSimplify`, `SqlToRelConverter` and other Calcite's classes
   
   And another question: shouldn't this issue be raised in Calcite's jira?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe closed pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected
URL: https://github.com/apache/flink/pull/21490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] swuferhong commented on pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
swuferhong commented on PR #21490:
URL: https://github.com/apache/flink/pull/21490#issuecomment-1347641325

   Caicite jira link: https://issues.apache.org/jira/browse/CALCITE-5431


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21490:
URL: https://github.com/apache/flink/pull/21490#issuecomment-1345983940

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "17f483c1719504d134acab11527b27dbc84f7dc1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "17f483c1719504d134acab11527b27dbc84f7dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 17f483c1719504d134acab11527b27dbc84f7dc1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe commented on pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on PR #21490:
URL: https://github.com/apache/flink/pull/21490#issuecomment-1362522963

   @swuferhong Currently, we had copied `RelMdUtil#numDistinctVals` to `FlinkRelMdUtil.numDistinctVals` and do some changes. does it not meet your requirements ？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe commented on a diff in pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on code in PR #21490:
URL: https://github.com/apache/flink/pull/21490#discussion_r1057104671


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelMdUtil.scala:
##########
@@ -247,6 +248,77 @@ object FlinkRelMdUtil {
     RexUtil.composeConjunction(rexBuilder, pushable, true)
   }
 
+  /**
+   * This method is copied from calcite RelMdUtil. This method should be removed once CALCITE-4351
+   * is fixed. See CALCITE-4351 and FLINK-19780.
+   *
+   * Computes the number of distinct rows for a set of keys returned from a join. Also known as NDV
+   * (number of distinct values).
+   *
+   * @param joinRel
+   *   RelNode representing the join
+   * @param joinType
+   *   type of join
+   * @param groupKey
+   *   keys that the distinct row count will be computed for
+   * @param predicate
+   *   join predicate
+   * @param useMaxNdv
+   *   If true use formula <code>max(left NDV, right NDV)</code>, otherwise use <code>left NDV *
+   *   right NDV</code>.
+   * @return
+   *   number of distinct rows
+   */
+  def getJoinDistinctRowCount(
+      mq: RelMetadataQuery,
+      joinRel: RelNode,
+      joinType: JoinRelType,
+      groupKey: ImmutableBitSet,
+      predicate: RexNode,
+      useMaxNdv: Boolean): Double = {
+    if ((predicate == null || predicate.isAlwaysTrue) && groupKey.isEmpty) return 1d

Review Comment:
   please format the copied code



##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelMdUtil.scala:
##########
@@ -247,6 +248,77 @@ object FlinkRelMdUtil {
     RexUtil.composeConjunction(rexBuilder, pushable, true)
   }
 
+  /**
+   * This method is copied from calcite RelMdUtil. This method should be removed once CALCITE-4351
+   * is fixed. See CALCITE-4351 and FLINK-19780.
+   *
+   * Computes the number of distinct rows for a set of keys returned from a join. Also known as NDV
+   * (number of distinct values).
+   *

Review Comment:
   please also mark which lines are changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] swuferhong commented on a diff in pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

Posted by GitBox <gi...@apache.org>.
swuferhong commented on code in PR #21490:
URL: https://github.com/apache/flink/pull/21490#discussion_r1057402776


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelMdUtil.scala:
##########
@@ -247,6 +248,77 @@ object FlinkRelMdUtil {
     RexUtil.composeConjunction(rexBuilder, pushable, true)
   }
 
+  /**
+   * This method is copied from calcite RelMdUtil. This method should be removed once CALCITE-4351
+   * is fixed. See CALCITE-4351 and FLINK-19780.
+   *
+   * Computes the number of distinct rows for a set of keys returned from a join. Also known as NDV
+   * (number of distinct values).
+   *

Review Comment:
   > please also mark which lines are changed
   
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org