You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2023/01/18 15:32:38 UTC

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21723: [FLINK-30749][security][runtime] Fix delegation token provider enabled flag documentation

gaborgsomogyi opened a new pull request, #21723:
URL: https://github.com/apache/flink/pull/21723

   ## What is the purpose of the change
   
   Delegation token providers can be turned off with [`security.delegation.token.provider.{serviceName}.enabled`](https://github.com/apache/flink/blob/b35cef5997568d75611307d11fca0dec415f99b4/flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DefaultDelegationTokenManager.java#L151-L154). The documentation however still contains the old config. In this PR I've fixed the doc.
   
   ## Brief change log
   
   Doc fix.
   
   ## Verifying this change
   
   No need any test.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] gaborgsomogyi commented on pull request #21723: [FLINK-30749][security][runtime] Fix delegation token provider enabled flag documentation

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21723:
URL: https://github.com/apache/flink/pull/21723#issuecomment-1387360395

   Thanks for pointing to the right direction. Will do a follow-up after the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zentol merged pull request #21723: [FLINK-30749][security][runtime] Fix delegation token provider enabled flag documentation

Posted by GitBox <gi...@apache.org>.
zentol merged PR #21723:
URL: https://github.com/apache/flink/pull/21723


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #21723: [FLINK-30749][security][runtime] Fix delegation token provider enabled flag documentation

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21723:
URL: https://github.com/apache/flink/pull/21723#issuecomment-1387273589

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f57528ac17c0f303da641e121e30b0e8dbb0f2b9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f57528ac17c0f303da641e121e30b0e8dbb0f2b9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f57528ac17c0f303da641e121e30b0e8dbb0f2b9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] gaborgsomogyi commented on pull request #21723: [FLINK-30749][security][runtime] Fix delegation token provider enabled flag documentation

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21723:
URL: https://github.com/apache/flink/pull/21723#issuecomment-1387262029

   cc @mbalassi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] gaborgsomogyi commented on pull request #21723: [FLINK-30749][security][runtime] Fix delegation token provider enabled flag documentation

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21723:
URL: https://github.com/apache/flink/pull/21723#issuecomment-1387331357

   a) This is dynamically generated, till now not seen such pattern (if you know how to do that plz share)
   b) This is a legacy doc which is coming from the Kerberos times. After this fix I'm intended to restructure it by adding to the config page
   
   > That should make sure that you can only refer to existing options
   
   This config is generated and it's depending on what kind of providers are on the classpath so this case we're not able to use the static class generator.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zentol commented on pull request #21723: [FLINK-30749][security][runtime] Fix delegation token provider enabled flag documentation

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21723:
URL: https://github.com/apache/flink/pull/21723#issuecomment-1387339515

   > This is dynamically generated, till now not seen such pattern (if you know how to do that plz share)
   
   There are ways to at least document it; see `MetricOptions#REPORTER_FACTORY_CLASS` for an example.
   Whether you can actually use the ConfigOption itself in prod depends on how exactly the code works.
   Maybe also take a look at `MetricOptions#forReporter`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org