[GitHub] [geode] upthewaterspout commented on pull request #5689: GEODE-8667: Duplicate online Oplog compaction after offline Oplog compaction

[GitBox <gi...@apache.org>]

upthewaterspout commented on pull request #5689:
URL: https://github.com/apache/geode/pull/5689#issuecomment-723359120


   I agree with Darrel.  Maybe the problem this test is finding is that the compaction is leaving behind an empty oplog (perhaps it generates an empty oplog to write to when it starts or something)?
   
   If that's the case though - it's not much of a bug, especially since it gets cleaned up on startup the next time. 
   
   If I remember what you were showing me earlier, I thought the compaction on startup after the offline compact was taking a long time. I wouldn't expect that to be the case if all it's doing is removing empty oplogs?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org